Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pyarrow 6.0 in matrix for CI testing #945

Merged
merged 6 commits into from
May 21, 2023
Merged

Add Pyarrow 6.0 in matrix for CI testing #945

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90ba854
try old pyarrow for CI
samster25 May 20, 2023
0fc011c
try again
samster25 May 21, 2023
476896c
fix matrix var
samster25 May 21, 2023
73a7e21
fix daft runner env var
samster25 May 21, 2023
e028a9f
change to exclude
samster25 May 21, 2023
e3f07c9
try exclude instead
samster25 May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,14 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.7', '3.10']
daft_runner: [py, ray]
daft-runner: [py, ray]
pyarrow-version: [6.0.1, 12.0]
exclude:
- daft-runner: ray
pyarrow-version: 6.0.1
- daft-runner: py
python-version: '3.10'

steps:
- uses: actions/checkout@v3
- uses: moonrepo/setup-rust@v0
Expand Down Expand Up @@ -53,6 +60,10 @@ jobs:
pip install --upgrade pip
pip install -r requirements-dev.txt

- name: Override pyarrow
if: ${{ matrix.pyarrow-version }}
run: pip install pyarrow==${{ matrix.pyarrow-version }}

- name: Build library and Test with pytest
run: |
source activate
Expand All @@ -63,10 +74,10 @@ jobs:
maturin develop
mkdir -p report-output && pytest --cov=daft --ignore tests/integration --durations=50
coverage combine -a --data-file='.coverage' || true
coverage xml -o ./report-output/coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft_runner }}.xml
cargo llvm-cov --no-run --lcov --output-path report-output/rust-coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft_runner }}.lcov
coverage xml -o ./report-output/coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}.xml
cargo llvm-cov --no-run --lcov --output-path report-output/rust-coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}.lcov
env:
DAFT_RUNNER: ${{ matrix.daft_runner }}
DAFT_RUNNER: ${{ matrix.daft-runner }}

- name: Upload coverage report
uses: actions/upload-artifact@v3
Expand Down Expand Up @@ -101,7 +112,7 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.7']
daft_runner: [py, ray]
daft-runner: [py, ray]
steps:
- uses: actions/checkout@v3
- uses: moonrepo/setup-rust@v0
Expand Down Expand Up @@ -151,7 +162,7 @@ jobs:
maturin develop --release
pytest tests/integration/ --durations=50
env:
DAFT_RUNNER: ${{ matrix.daft_runner }}
DAFT_RUNNER: ${{ matrix.daft-runner }}

- name: Send Slack notification on failure
uses: slackapi/slack-github-action@v1.24.0
Expand Down