Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder admix plots #71

Merged
merged 36 commits into from
Jan 21, 2025
Merged

Reorder admix plots #71

merged 36 commits into from
Jan 21, 2025

Conversation

eviecarter33
Copy link
Contributor

Fix tidy.q_matrix infrastructure and test gt_admix objects

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 97.60479% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.58%. Comparing base (c254875) to head (93af987).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
R/q_matrix.R 94.23% 3 Missing ⚠️
R/gt_snmf.R 98.94% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   85.96%   86.58%   +0.62%     
==========================================
  Files          96       97       +1     
  Lines        3690     3839     +149     
==========================================
+ Hits         3172     3324     +152     
+ Misses        518      515       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dramanica
Copy link
Member

dramanica commented Jan 17, 2025

Amazing work @eviecarter33! A couple of minor things to do before we can merge in:

  • The website needs gt_snmf to be added to the pkgdown yaml.
  • There are a few lines not tested that are highlighted by codecov. Looking at them, it seems that we don't test a couple of combinations of metadata input for q_matrix. It would be nice to add those to the tests (it shouldn't be much work given all the tests that you have created, it should just be a matter to add that particular permutation of metadata).

@dramanica dramanica merged commit 47e2dd2 into main Jan 21, 2025
8 of 9 checks passed
@dramanica dramanica deleted the reorder_admix_plots branch January 21, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants