refactor(chatwoot): remove message ids cache in chatwoot to use chatwoot's api itself #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cache Remove use of disc cache for optimize performance. To make this, we need change to use only one instance of ChatwootService in entire application.
… to be ignored. With this, messageCache is used to support Chatwoot version <= 3.3.1. After this version we can remove use of message cache and use only the source_id field to check chatwoot's webhook needs to be ignored. It's have much better performance.
…oot's api itself. Remove use of disc cache to optimize performance. BREAKING CHANGE: to make this, we need to use the param `source_id` from message in chatwoot. This param is only available from api in chatwoot version => 3.4.0.
|
my cpu thanks you, |
Good Nestor, with this everybody with version <= 3.4.0 can use this PR too! This PR helps a lot with performance in chatwoot integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(chatwoot): remove message ids cache in chatwoot to use chatwoot's api itself
Remove use of disc cache to optimize performance.
BREAKING CHANGE: to make this, we need to use the param
source_idfrom message in chatwoot.This param is only available from api in chatwoot version => 3.4.0.