Upload tasks: MovieChat-1K, VDC #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcz358
reviewed
Oct 22, 2024
| @@ -0,0 +1,16 @@ | |||
| task: vdc_background | |||
| dataset_path: ${YOUR_DATASET_PATH}/background_test | |||
There was a problem hiding this comment.
Is this redundant? Or wrongly added.
kcz358
reviewed
Oct 22, 2024
lmms_eval/tasks/vdc/vdc_camera.yaml
Outdated
| @@ -0,0 +1,16 @@ | |||
| task: vdc_camera | |||
| dataset_path: ${YOUR_DATASET_PATH}/camera_test | |||
kcz358
reviewed
Oct 22, 2024
| @@ -0,0 +1,16 @@ | |||
| task: vdc_detailed | |||
| dataset_path: ${YOUR_DATASET_PATH}/detailed_test | |||
kcz358
reviewed
Oct 22, 2024
| @@ -0,0 +1,16 @@ | |||
| task: vdc_main_object | |||
| dataset_path: ${YOUR_DATASET_PATH}/main_object_test | |||
kcz358
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Hi, there are some minor issues in the yaml file. If it is not needed, you can remove it or correct it. Thank you!
Also, can you format the code using pre-commit to pass the linting issue? You can pass the lint test by using
pip install pre-commit
pre-commit install
pre-commit run --all-files
lmms_eval/tasks/vdc/vdc_short.yaml
Outdated
| @@ -0,0 +1,16 @@ | |||
| task: vdc_short | |||
| dataset_path: ${YOUR_DATASET_PATH}/short_test | |||
kcz358
approved these changes
Oct 26, 2024
ZhaoCinyu
pushed a commit
to ZhaoCinyu/lmms-eval
that referenced
this pull request
Dec 9, 2024
* moviechat-1K, VDC * Fix datasets error * pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload two video understanding tasks: MovieChat-1K, VDC