Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create file with standardized port UN-LOCODES and names, which are used for all web scrapers #30

Open
EwoutH opened this issue Oct 24, 2022 · 3 comments
Labels

Comments

@EwoutH
Copy link
Owner

EwoutH commented Oct 24, 2022

Ports are now defined in each scraper, this should be loaded for all scraper from one single file.

@EwoutH EwoutH added the Prio1 label Oct 25, 2022
@EwoutH
Copy link
Owner Author

EwoutH commented Oct 31, 2022

@imvs95 I'm now using these countries as origin countries, am I missing any?

{'AR': 'Argentina',
 'BR': 'Brazil',
 'CL': 'Chile',
 'CO': 'Colombia',
 'EC': 'Ecuador',
 'GF': 'French Guiana',
 'GY': 'Guyana',
 'PE': 'Peru',
 'SR': 'Suriname',
 'UY': 'Uruguay',
 'VE': 'Venezuela',
 'VN': 'Viet Nam',
 'CW': 'Curaçao'}

@EwoutH
Copy link
Owner Author

EwoutH commented Oct 31, 2022

Checken:

  • Zuid: Paraguay, Guyana,
  • Midden: Alles
  • Viet nam: Cambodja, Thailand, Maleisië

@EwoutH
Copy link
Owner Author

EwoutH commented Oct 31, 2022

For now I added:

{'PY': 'Paraguay',
 'GY': 'Guyana',
 'KH': 'Cambodia'}

Resulting in this full set of OD countries:

origin = ["BR", "CO", "VE", "SR", "CW", "GY", "GF", "UY", "AR", "CL", "PE", "EC", "VN", "PY", "GY", "KH"]
destination = ["NL", "BE"]

I will add Latin-America and more in the Vietnam area once scrapers prove to be stable and have performance to spare.

This should still be in a central file somewhere.

EwoutH added a commit that referenced this issue Oct 31, 2022
{'PY': 'Paraguay',
 'GY': 'Guyana',
 'KH': 'Cambodia'}

See #30 (comment)
EwoutH added a commit that referenced this issue Oct 31, 2022
Add data for Paraguay, Guyana and Cambodia for 2022-10-31.

See #30 (comment)

Co-authored-by: EwoutH <EwoutH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant