Upgrade flake8 use typedecl 2 #340
Conversation
* tests: added llnl specific tests from getting-started documentation * tests: divided llnl doc tests into subfolder within tests * linting: applied type annotations * tests: Added doc tests with executor parameters * deleted: old folder of slurm/lsf specific tests * getting started doc tests: fixed status callback test * addressing linting * addressing linting
The reason why flak8 was complaining is because of the removal of support for `# type: xyz` style declarations. So convert all those to proper type declarations.
| self.kill_flag = False | ||
| self.process = None # type: Optional[subprocess.Popen[bytes]] | ||
| self.process: Optional[subprocess.Popen[bytes]] = None |
There was a problem hiding this comment.
That's an interesting one - haven't seen that documented as type. Where did you find this?
There was a problem hiding this comment.
https://docs.python.org/3/library/subprocess.html#subprocess.Popen
It turns out Popen is a class. You'd think it's something like Open returning a File or, you know, Verb applied to Noun produces Noun, but no.
There was a problem hiding this comment.
Ah, sorry, I wasn't clear. Yes, Popen is a class - but classname[bytes] is not a syntax I have seen anywhere before.
I found one google hit by now which indicates that the Popen class is marked as generic - wasn't aware of that...
There was a problem hiding this comment.
I see. Well, if you don't put the type parameters, mypy will produce an error. I'm not entirely sure where I found what that parameter is (str/bytes based on whether you open the output streams in text or binary mode), since I can't find a clear statement of that in the official python documentation.
flake8 6.0.0 (and corresponding pyflakes) removed support for
# type: abc, which caused unused import errors. The solution was to change those type declarations to the "proper" format (var: <type> = <value>).This time on top of main.