Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "comment" field is not necessarily present for all states. #490

Merged
merged 1 commit into from
Jul 9, 2024
Merged

The "comment" field is not necessarily present for all states. #490

merged 1 commit into from
Jul 9, 2024

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Jul 8, 2024

Fixes #489

@hategan hategan requested review from mtitov and andre-merzky July 8, 2024 22:44
mtitov
mtitov approved these changes Jul 9, 2024
View reviewed changes
Copy link

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@hategan hategan merged commit 30fdb5e into main Jul 9, 2024
13 checks passed
@hategan hategan deleted the pbs_comment_fix branch July 9, 2024 19:37
@mtitov mtitov mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtitov mtitov mtitov approved these changes

@andre-merzky andre-merzky Awaiting requested review from andre-merzky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PBSPro - KeyError for comment (Polaris@ALCF)
2 participants
@hategan @mtitov