Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hand rolled interpolation #1393

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix hand rolled interpolation #1393

wants to merge 3 commits into from

Conversation

moprak-nrel
Copy link
Contributor

Summary

Replace hand rolled interpolation with interp::linear and interp::bilinear as appropriate.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number: fixes #1364

@moprak-nrel moprak-nrel changed the title Mmc bilinear update Fix hand rolled interpolation Dec 6, 2024
@marchdf marchdf mentioned this pull request Dec 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hand rolled interpolation should be fixed
1 participant
@moprak-nrel