Rewrote cmake build system to improve organization and usability #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddement
force-pushed
the
rework_cmake_redux
branch
2 times, most recently
from
4474e06 to
0754f85
Compare
IMPORTANT CHANGES: Options have been renamed to OpenTurbine_* instead of OTURB Tests are now build by default The unit test executable now lives in tests/unit_tests, not the top level build directory The built libraries now live in src, not the top level build directory To run unit tests which use shared libraries, you must copy them into the directory where you're running your unit test executable. For example, from your build directory, run `cp src/*.dll ./` followed by `./tests/unit_tests/openturbine_unit_tests`
ddement
force-pushed
the
rework_cmake_redux
branch
from
0754f85 to
186c828
Compare
deslaughter
reviewed
Jul 31, 2024
I updated the documentation. In fairness, it hadn't been updated in 1.5 years (it completely missed the KokkosKernels only days), and I wouldn't be surprised if other parts are also woefully out of date. |
deslaughter
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT CHANGES:
Options have been renamed to
OpenTurbine_*instead ofOTURBTests are now built by default
The unit test executable now lives in
tests/unit_tests, not the top level build directoryThe built libraries now live in
src, not the top level build directoryTo run unit tests which use shared libraries, you must copy them into the directory where you're running your unit test executable. For example, from your build directory, run
cp src/*.dll ./followed by./tests/unit_tests/openturbine_unit_tests