Fixes segfault in regression test from change in OpenFAST API #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddement
force-pushed
the
fix_openfast_setfault
branch
3 times, most recently
from
cb48806 to
aca8fa2
Compare
deslaughter
approved these changes
Dec 24, 2024
ddement
force-pushed
the
fix_openfast_setfault
branch
from
aca8fa2 to
3211425
Compare
faisal-bhuiyan
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this regression test throws many warnings that imply we may have other errors in our usage of the library. There are no correctness checks (only step convergence) in the regression test, so the results will need to be compared to a previously verified version of OpenTurbine.
This change does fix the segfault introduced by the latest OpenFAST API change and I have verified that the output warnings are identical to main when linked against a version of OpenFAST using the old API.