-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exiled.Events]
Added PlacingPickupIntoPocketDimension
event.
#2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misaka-ZeroTwo
added
help wanted
Extra attention is needed
Do not merge
Don't merge this PR
labels
Nov 15, 2023
i will see what i can do there |
louis1706
reviewed
Jan 26, 2024
ShouldWarning -> ShouldWarn
NaoUnderscore
added
enhancement
New feature or request
regarding-events
An issue or PR targeting the Exiled Events project
P2
Medium priority
and removed
help wanted
Extra attention is needed
Do not merge
Don't merge this PR
labels
Feb 3, 2024
NaoUnderscore
changed the title
Added 106 Pocket Dimension pickup handler
Feb 3, 2024
[Exiled.Events]
Added PlacingPickupIntoPocketDimension
event.
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
P2
Medium priority
regarding-events
An issue or PR targeting the Exiled Events project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickups have different behaviors in 106's pocket dimension. They have flags that determine if they have a 50%, 30%, or 0% chance of being deleted, playing sounds when a pickup does leave the pocket dimension, and determines where it will be ejected back into the rest of the facility.
I have no idea how to make a transpiler for this, but my hope is that this makes a solid start.