Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resonance] New SCP Events & Disguise Prefix To Transpiler #2739

Merged
merged 32 commits into from
Jul 21, 2024
Merged

[Resonance] New SCP Events & Disguise Prefix To Transpiler #2739

merged 32 commits into from
Jul 21, 2024

Conversation

xNexusACS
Copy link
Member

@xNexusACS xNexusACS commented Jul 20, 2024 •
edited
Loading

Additions

  • Scp0492 Attacking Event Args.
  • Scp096 Attacking Event Args.
  • Scp173 Attacking Event Args.

(All 3 events if denied, prevents the hitmarker from appearing and hit sound from playing)

Changes

  • Disguising Patch is now a transpiler instead of a prefix.

@xNexusACS xNexusACS self-assigned this Jul 20, 2024
@github-actions github-actions bot added regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch labels Jul 20, 2024
iamalexrouse
iamalexrouse approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@iamalexrouse iamalexrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add requires-testing labels if needed.

@xNexusACS xNexusACS added the requires-testing Things need to be verified by an Exiled Developer/Contributor label Jul 20, 2024
@xNexusACS
Copy link
Member Author

xNexusACS commented Jul 20, 2024 •
edited
Loading

Please add requires-testing labels if needed.

I forgot about the tag sorry, the only thing that needs to be tested is the zombie event, everything else is tested

@xNexusACS xNexusACS marked this pull request as ready for review July 20, 2024 11:13
@xNexusACS xNexusACS changed the title [Resonance] New SCP Events, Fix Strangling Crash & Disguise Prefix To Transpiler [Resonance] New SCP Events & Disguise Prefix To Transpiler Jul 20, 2024
@xNexusACS xNexusACS added tested This PR has been built and tested and does not cause any obvious errors. and removed requires-testing Things need to be verified by an Exiled Developer/Contributor labels Jul 20, 2024
@xNexusACS
Copy link
Member Author

tested

@NaoUnderscore NaoUnderscore merged commit 2904ce6 into Exiled-Team:dev Jul 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamalexrouse iamalexrouse iamalexrouse approved these changes

Assignees

@xNexusACS xNexusACS

Labels
regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch tested This PR has been built and tested and does not cause any obvious errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xNexusACS @iamalexrouse @NaoUnderscore