Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable libiconv support when building with Visual Studio. #1253

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Disable libiconv support when building with Visual Studio. #1253

merged 1 commit into from
Jul 19, 2020

Conversation

clanmills
Copy link
Collaborator

No description provided.

@clanmills clanmills added this to the v0.27.4 milestone Jul 19, 2020
@clanmills clanmills requested a review from piponazo July 19, 2020 16:13
@clanmills clanmills self-assigned this Jul 19, 2020
@clanmills clanmills mentioned this pull request Jul 19, 2020
Closed
@clanmills
Copy link
Collaborator Author

As usual, GitLab fails this PR, although I don't understand why.

@clanmills clanmills merged commit be7d5c4 into 0.27-maintenance Jul 19, 2020
@clanmills clanmills deleted the fix_1250_libiconv_msvc_0.27 branch July 19, 2020 21:53
@clanmills clanmills added the CMake Configuration issues related with CMake label Jul 23, 2020
@clanmills clanmills mentioned this pull request Jan 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo Awaiting requested review from piponazo

Assignees

@clanmills clanmills

Labels
CMake Configuration issues related with CMake
Projects
None yet
Milestone
v0.27.4
Development

Successfully merging this pull request may close these issues.
1 participant
@clanmills