-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quadratic loops in pentaxmn_int.cpp #1910
Fix quadratic loops in pentaxmn_int.cpp #1910
Conversation
…l?id=38887 Fix quadratic loops.
Codecov Report
@@ Coverage Diff @@
## main #1910 +/- ##
=======================================
Coverage 60.87% 60.87%
=======================================
Files 96 96
Lines 19041 19043 +2
Branches 9726 9726
=======================================
+ Hits 11591 11593 +2
Misses 5138 5138
Partials 2312 2312
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 0.27-maintenance |
Command
|
Fix quadratic loops in pentaxmn_int.cpp (backport #1910)
Fixes: #1909
I didn't add a test because the poc attached to #1909 is quite big. (You need a large file for the quadratic loop to take a noticeable amount of time to run.)
The fix is to search from the current position, rather than repeatedly searching from the beginning of the string.