-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade documentation regarding CMake & Tests #2088
Conversation
Now we are hardcoding the C++17 requirement into cmake/compilerFlags.cmake
Codecov Report
@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
- Coverage 62.08% 61.87% -0.22%
==========================================
Files 96 96
Lines 19153 19059 -94
Branches 9798 9782 -16
==========================================
- Hits 11891 11792 -99
- Misses 4967 4984 +17
+ Partials 2295 2283 -12
Continue to review full report at Codecov.
|
BTW, I agree with you that Documenting everything with conan/cmake/ctest commands runs everywhere. It's early days to call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's really good. Can you update the trailer with the revision date and remove my name/email. If you wish, you can add your name. I did this as a courtesy, however it's quite unnecessary. Putting the revision date in the document is useful.
I think I have covered all the points addressed by @kmilos . Please let me know if I forgot something |
As discussed at #2082 and #2080, I decided to spend some time reviewing the documentation regarding CMake and how to run the tests.