Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade rollup from 1.16.6 to 3.29.5 #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Exnadella
Copy link
Owner

@Exnadella Exnadella commented Sep 24, 2024

User description

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • packages/bundler/package.json
  • packages/bundler/package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Cross-site Scripting (XSS)
SNYK-JS-ROLLUP-8073097
  648  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Scripting (XSS)


PR Type

enhancement, dependencies


Description

  • Upgraded the rollup dependency from version 1.3.0 to 3.29.5 in package.json to address a Cross-site Scripting (XSS) vulnerability.
  • Updated package-lock.json to reflect changes in rollup dependency version.
  • This upgrade aims to fix the vulnerability identified by Snyk with ID SNYK-JS-ROLLUP-8073097.

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Upgrade rollup dependency to address security vulnerability

packages/bundler/package.json

  • Upgraded rollup dependency from version 1.3.0 to 3.29.5.
  • Addressed a security vulnerability related to rollup.
  • +1/-1     
    package-lock.json
    Update package-lock.json for rollup upgrade                           

    packages/bundler/package-lock.json

    • Updated lock file to reflect the upgraded rollup dependency.
    +1941/-1949
    Additional files (token-limit)
    package-lock.json
    ...                                                                                                           

    packages/bundler/package-lock.json

    ...

    +1941/-1949

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    …on to reduce vulnerabilities
    
    The following vulnerabilities are fixed with an upgrade:
    - https://snyk.io/vuln/SNYK-JS-ROLLUP-8073097
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Update multiple dependencies to their latest compatible versions

    Consider updating other dependencies to their latest compatible versions to ensure
    all packages work well together with the new rollup version.

    packages/bundler/package.json [35]

     "rollup": "^3.29.5",
    +"polymer-analyzer": "^3.2.4",
    +"mkdirp": "^1.0.4",
    +"parse5": "^6.0.1",
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion to update other dependencies to their latest compatible versions is a good practice for maintaining compatibility and security. However, it is not crucial unless there are known issues with the current versions, hence a moderate score. The suggestion does not address any specific bugs or security vulnerabilities directly.

    7

    💡 Need additional feedback ? start a PR chat

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants