Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade del from 3.0.0 to 8.0.0 #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Exnadella
Copy link
Owner

@Exnadella Exnadella commented Oct 13, 2024

User description

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • packages/cli/package.json
    • packages/cli/package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 631/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 6.2
Missing Release of Resource after Effective Lifetime
SNYK-JS-INFLIGHT-6095116
Yes Proof of Concept
medium severity 479/1000
Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)
SNYK-JS-MINIMATCH-3050818
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: del The new version differs by 55 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)


PR Type

enhancement, dependencies


Description

  • Upgraded del package from version 3.0.0 to 8.0.0 in both package.json and package-lock.json to address vulnerabilities.
  • Added new dependencies such as @nodelib/fs.scandir, @nodelib/fs.walk, and fast-glob to support the updated del package.
  • Updated several existing dependencies to newer versions to enhance security and functionality.
  • Introduced optional and devOptional dependencies for better package management.

Changes walkthrough 📝

Relevant files
Dependencies
package-lock.json
Upgrade dependencies and enhance package-lock.json             

packages/cli/package-lock.json

  • Upgraded del package from version 3.0.0 to 8.0.0.
  • Added new dependencies such as @nodelib/fs.scandir, @nodelib/fs.walk,
    and fast-glob.
  • Updated several existing dependencies to newer versions.
  • Introduced optional and devOptional dependencies for better package
    management.
  • +214/-64
    package.json
    Upgrade del package to address vulnerabilities                     

    packages/cli/package.json

    • Upgraded del package from version 3.0.0 to 8.0.0.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    161 - Fully compliant

    Fully compliant requirements:

    • Upgrade rollup from 0.64.1 to 3.29.5
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Update
    Verify that the upgrade of del from 3.0.0 to 8.0.0 doesn't introduce any breaking changes or compatibility issues with existing code.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Update other dependencies to their latest compatible versions for consistency and potential improvements

    Consider updating other dependencies to their latest compatible versions to ensure
    consistency and potentially benefit from bug fixes and new features.

    packages/cli/package.json [59-61]

     "del": "^8.0.0",
    -"findup-sync": "^0.4.2",
    -"globby": "^8.0.1",
    +"findup-sync": "^4.0.0",
    +"globby": "^11.1.0",
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: The suggestion to update other dependencies to their latest versions could improve consistency and potentially bring bug fixes and new features. However, it requires careful consideration of compatibility and testing, which is not addressed in the suggestion.

    5
    Best practice
    Review newly added dependencies for necessity and potential conflicts

    Review and potentially update the newly added dependencies (@nodelib/fs.scandir,
    @nodelib/fs.walk, fast-glob, etc.) to ensure they are necessary and don't introduce
    any conflicts or vulnerabilities.

    packages/cli/package-lock.json [666-681]

    +// After thorough review and testing
     "@nodelib/fs.scandir": {
       "version": "2.1.5",
       "resolved": "https://registry.npmjs.org/@nodelib/fs.scandir/-/fs.scandir-2.1.5.tgz",
       "integrity": "sha512-vq24Bq3ym5HEQm2NKCr3yXDwjc7vTsEThRDnkp2DK9p1uqLR+DHurm/NOTo0KG7HYHU7eppKZj3MyqYuMBf62g==",
       "requires": {
         "@nodelib/fs.stat": "2.0.5",
         "run-parallel": "^1.1.9"
       },
    • Apply this suggestion
    Suggestion importance[1-10]: 4

    Why: The suggestion to review newly added dependencies for necessity and potential conflicts is a good practice but is not actionable by itself. It lacks specific guidance or changes, thus having a limited direct impact on the code.

    4

    💡 Need additional feedback ? start a PR chat

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants