Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requireValidation for oneOf/anyOf/allOf #68

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Jun 24, 2020

Fixes: #64

Depends on #67.

@ChALkeR ChALkeR added the fix label Jun 24, 2020
@ChALkeR ChALkeR self-assigned this Jun 24, 2020
@ChALkeR ChALkeR force-pushed the chalker/fix-subclauses-enforcevalidation branch 10 times, most recently from 3de4f3b to 396e3ae Compare June 24, 2020 22:03
@ChALkeR ChALkeR changed the base branch from master to chalker/const-enum-short June 24, 2020 22:04
@ChALkeR ChALkeR marked this pull request as ready for review June 24, 2020 22:04
@ChALkeR ChALkeR requested a review from kklash June 24, 2020 22:06
Base automatically changed from chalker/const-enum-short to master June 24, 2020 22:19
@kklash
Copy link
Contributor

kklash commented Jun 24, 2020

Needs rebase

@ChALkeR ChALkeR force-pushed the chalker/fix-subclauses-enforcevalidation branch from 396e3ae to 071088b Compare June 24, 2020 22:26
@ChALkeR
Copy link
Contributor Author

ChALkeR commented Jun 24, 2020

Rebased

@ChALkeR ChALkeR force-pushed the chalker/fix-subclauses-enforcevalidation branch from 071088b to f53c2bd Compare June 24, 2020 22:28
Copy link
Contributor

@kklash kklash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Great test

@kklash kklash merged commit 92c72c7 into master Jun 24, 2020
@kklash kklash deleted the chalker/fix-subclauses-enforcevalidation branch June 24, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using oneOf for object type results in always-failing condition
2 participants