JUnit5 extension classes #28

cmathiesen · 2019-08-12T13:28:37Z

Fixes issue #22.
I've created some extension classes for each of the JUnit4 rules, that matches the same structure as the rules, and use the @RegisterExtension annotation. An upgrade to Java 8 was necessary to use JUnit5.

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

patduin · 2019-08-12T19:19:20Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+      init();
+      beforeTest();
+    } catch (Throwable throwable) {
+      LOG.error("Unable to initialise BeejuJUnit extension", throwable);


Not really useful, imagine running a test that is not working and you only have this this error in the logs somewhere., that's hard to debug. Just remove the try catch and let all the exceptions bubble up. Fail fast

patduin · 2019-08-12T19:19:38Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+    afterTest();
+    try {
+      FileUtils.deleteDirectory(tempDirectory.toFile());
+    } catch (IOException e) {


same here (also never printStacktrace please).

patduin · 2019-08-12T19:21:10Z

src/main/java/com/hotels/beeju/extensions/HiveMetaStoreJUnitExtension.java

+ *           &quot;--url&quot;,
+ *           hive.connectionURL(),
+ *           &quot;--user&quot;,
+ *           HiveMetaStoreJUnitRule.HSQLDB_USER,


could you test if this still works, I think we are using Derby DB so those USER/PASSWORD things are wrong. We definitely shouldn't refer to the Rule here.

patduin · 2019-08-12T19:27:14Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+   *
+   * @throws Throwable If the initialisation fails.
+   */
+  protected void init() throws Throwable {


Maybe throws Exception (that's eventually what the beforeEach does as well)

patduin · 2019-08-12T19:31:24Z

src/main/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtension.java

+import com.hotels.beeju.core.ThriftHiveMetaStoreCore;
+
+/**
+ * A JUnit Extension that creates a Hive Metastore Thrift service backed by a Hive Metastore using an HSQLDB in-memory


we're not using HSQLDB but Derby: can please change it to in-memory database no reason to mention the type. I think I neglected to update this when we moved to Derby, sorry :(

src/main/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtension.java

patduin · 2019-08-12T19:39:04Z

src/test/java/com/hotels/beeju/extensions/HiveServer2JUnitExtensionTest.java

+  }
+
+  @Test
+  public void addPartition() throws Exception {


There is lots of duplication in between this class and the com.hotels.beeju.HiveServer2JUnitRuleTest. Perhaps some of those tests can move to com.hotels.beeju.core.HiveServer2CoreTest and the Rule/Extension test can test just the logic of the Rule/Extension?

Yeah I had a similar thought when looking at it. But I think the issue with doing that is these tests all use different elements of the rule/extension which isn't available in the HiveServer2Core, such as the temporary directory and the server connection URL. Maybe some of the reused logic could be moved into a test resources class?

I think it's better to move it to a core test as it is core logic we're testing. The core test should just provide a temporary directory and a server connection url.

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

coveralls · 2019-08-14T17:15:56Z

Coverage decreased (-21.1%) to 69.675% when pulling f4c7901 on junit5-extensions into 6bfa56d on master.

AnanaMJ · 2019-08-16T10:41:28Z

README.md

 This rule creates an in-memory Hive database and a Thrift Hive Metastore service on top of this. This can then be used to perform Hive Thrift API calls in a test. The rule exposes a Thrift URI that can be injected into the class under test and a Hive Metastore Client which can be used for data setup and assertions.

-Example usage: Class under test creates a table via the Hive Metastore Thrift API. 
+Example @Rule usage: Class under test creates a table via the Hive Metastore Thrift API. 


@Rule would look good wrapped in back ticks :)

AnanaMJ · 2019-08-16T10:41:40Z

README.md

 This rule creates an in-memory Hive database without a Thrift Hive Metastore service. This can then be used to perform Hive API calls directly (i.e. without going via Hive's Metastore Thrift service) in a test.

-Example usage: Class under test creates a partition using an injected Hive Metastore Client. 
+Example @ Rule usage: Class under test creates a partition using an injected Hive Metastore Client. 


and there is a space between @ and Rule

AnanaMJ · 2019-08-16T11:19:31Z

src/main/java/com/hotels/beeju/HiveMetaStoreJUnitRule.java

 import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;

+import com.hotels.beeju.core.HiveMetaStoreCore;
+
 /**
 * A JUnit {@link Rule} that creates a Hive Metastore backed by an HSQLDB in-memory database.


This showed in red for me in IntelliJ. But after adding an import for org.junit.Rule, it looked fine. And there are 2 other classes that have javadocs rules for unimported linked classes. It looks like these are unresolved references inside the Javadoc. Do we care about these or not?

AnanaMJ · 2019-08-16T11:23:17Z

src/main/java/com/hotels/beeju/core/BeejuCore.java

+   * This method can be overridden to provide additional initialisations.
+   * </p>
+   *
+   * @throws Throwable If the initialisation fails.


Small thing, but it should be lowercase "i" in "If". And it throws IOException, not Throwable, right?

Oh it looks like all the javadocs with @throws Exception ... starts with uppercased "i" in "If" so nevermind about that. But I still think the exception should be IOException :)

Yep good spot!

AnanaMJ · 2019-08-16T11:33:08Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+  }
+
+  /**
+   * @return @see com.hotels.beeju.core.BeejuCore#connectionURL()


Should this be @link instead of @see?

Yes it should :)

AnanaMJ · 2019-08-16T14:58:07Z

src/test/java/com/hotels/beeju/extensions/HiveMetaStoreJUnitExtensionTest.java

+
+  @Test
+  public void createDatabaseNullName() {
+    Assertions.assertThrows(NullPointerException.class, () -> {


this can be on one line:

Assertions.assertThrows(NullPointerException.class, () -> hiveDefaultName.createDatabase(null));

AnanaMJ · 2019-08-16T14:59:12Z

src/test/java/com/hotels/beeju/extensions/HiveServer2JUnitExtensionTest.java

+
+  @Test
+  public void defaultDatabaseName() {
+    HiveServer2JUnitExtension server = new HiveServer2JUnitExtension(DATABASE, null);


Is this needed here? Because the test passes without it too.

+1 it's unused

AnanaMJ · 2019-08-16T15:13:42Z

src/test/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtensionTest.java

+
+  @Test
+  public void createExistingDatabase() {
+    Assertions.assertThrows(AlreadyExistsException.class, () -> {


The lambdas from here and the next two tests can also be on one line each :)

Maybe except for this one, because it doesn't fit on one line, so it would be something like this

Assertions.assertThrows(AlreadyExistsException.class, () -> hiveDefaultName.createDatabase(hiveDefaultName.databaseName()));

AnanaMJ · 2019-08-16T15:16:40Z

src/test/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtensionTest.java

+  @Test
+  public void customProperties() {
+    Map<String, String> conf = new HashMap<>();
+    conf.put("my.custom.key", "my.custom.value");


If you want this to be on one line, I found out recently that you can do

Map<String, String> conf = Collections.singletonMap("my.custom.key", "my.custom.value");

AnanaMJ · 2019-08-16T15:23:52Z

src/test/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtensionTest.java

+
+    Database database = hive.client().getDatabase(databaseName);
+
+    assertThat(database.getName(), is(databaseName));


This is more of a personal preference, but I wouldn't split the declaration of databaseName and of database from the assert for the database names. To me they should be together because they're about the same thing.

I would also add a new line between line 81 and 83.

Like I said, this is personal preference, so take it or leave it 🙂

patduin · 2019-08-19T12:37:57Z

pom.xml

+    <dependency>
+      <groupId>hsqldb</groupId>
+      <artifactId>hsqldb</artifactId>
+      <version>1.8.0.1</version>


This is for the javadoc right? <scope>provided</scope> should be ok

Ah yeah, but seeing as we took it out of the JavaDoc i'll just get rid of it here

even better

src/main/java/com/hotels/beeju/core/BeejuCore.java

patduin · 2019-08-19T12:53:25Z

src/main/java/com/hotels/beeju/core/BeejuCore.java

+
+  public void deleteTempDir() {
+    try {
+      Files.walkFileTree(tempDir, new SimpleFileVisitor<Path>() {


commons IO solves this for you: FileUtils.deleteDirectory(tempDir);

I've added this instead which is much neater, however this still needs to handle an IOException but the base class that we are extending BeejuJUnitRule from doesn't let you throw exceptions in the signature of after() (which calls this deleteTempDir() method) so it has to be caught in a try/catch - is there a better method of handling it than printing the stack trace?

I think this should still just throw cause it can't handle it. In the rule it can try catch(){throw new runtimeException(e);} and I think in the extension where it is called it will just be thrown no need to do anything there.

patduin · 2019-08-19T12:54:10Z

src/main/java/com/hotels/beeju/core/BeejuCore.java

+        }
+      });
+    } catch (IOException e) {
+      e.printStackTrace();


Never printStacktrace please, that's pretty much the same as ignoring the exception altogether.
Just throw the exception in the method signature

src/main/java/com/hotels/beeju/core/BeejuCore.java

patduin · 2019-08-19T13:06:06Z

src/main/java/com/hotels/beeju/core/BeejuCore.java

@@ -75,11 +87,27 @@ public BeejuCore(String databaseName, Map<String, String> configuration) {
      // overriding default derby log path to go to tmp
      String derbyLog = File.createTempFile("derby", ".log").getCanonicalPath();
      System.setProperty("derby.stream.error.file", derbyLog);
+
+      //Creating temporary folder
+      init();


I think either have an external class call init() and don't init in the constructor or leave the init() call here and make the method private? Nothing is overwriting it atm so it can be private

if private also please rename to something like: createWarehousePath()

yeah i'll make this private and change the name, this part should happen during core initialisation to have access to the temporary directory. Although it is only 2 lines, which could be added to the constructor instead?

src/main/java/com/hotels/beeju/BeejuJUnitRule.java

patduin · 2019-08-19T13:19:35Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+   *
+   * @throws Exception If the extension cannot be prepared for a new test.
+   */
+  protected abstract void beforeTest() throws Exception;


Do we really need this method, can't we just override beforeEach in the subclasses?

i guess technically no we dont need it, but adding beforeTest() as an abstract method means we keep the logic of calling BeejuCore methods here in BeejuJUnitExtension (init() and createDatabase()) and then handle calling the HiveMetaStoreCore (or other variation) methods (initialise()) in the corresponding Extension class which seems like a more logical way of structuring it to me

patduin · 2019-08-19T13:19:56Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+   * This method is called before the warehouse directory is deleted.
+   * </p>
+   */
+  protected abstract void afterTest() throws Exception;


Do we really need this method, can't we just override afterEach in the subclasses?

src/main/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtension.java

patduin · 2019-08-19T13:29:15Z

src/test/java/com/hotels/beeju/extensions/HiveServer2JUnitExtensionTest.java

+
+  @Test
+  public void defaultDatabaseName() {
+    HiveServer2JUnitExtension server = new HiveServer2JUnitExtension(DATABASE, null);


+1 it's unused

abhimanyugupta07

Looks mostly good to me.

src/test/java/com/hotels/beeju/core/HiveServer2CoreTest.java

src/test/java/com/hotels/beeju/extensions/HiveServer2JUnitExtensionTest.java

src/main/java/com/hotels/beeju/HiveMetaStoreJUnitRule.java

patduin

looks good

AnanaMJ · 2019-08-22T07:53:05Z

src/main/java/com/hotels/beeju/BeejuJUnitRule.java

 import java.util.Map;

 import org.apache.hadoop.hive.conf.HiveConf;
 import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;
 import org.apache.thrift.TException;
 import org.junit.rules.ExternalResource;
-import org.junit.rules.TemporaryFolder;

 import com.google.common.annotations.VisibleForTesting;


Not sure how this import stayed here because the save actions should've removed it, but it should be removed :)

AnanaMJ · 2019-08-22T07:56:11Z

src/main/java/com/hotels/beeju/core/BeejuCore.java

+import java.nio.file.FileVisitResult;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.SimpleFileVisitor;


Same here, there are some imports that aren't needed.

AnanaMJ · 2019-08-22T07:56:42Z

src/main/java/com/hotels/beeju/core/BeejuCore.java


 public class BeejuCore {

+  private static final Logger LOG = LoggerFactory.getLogger(BeejuCore.class);


This isn't used

AnanaMJ · 2019-08-22T08:03:07Z

src/test/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtensionTest.java

+  @Test
+  public void createExistingDatabase() {
+    Assertions.assertThrows(AlreadyExistsException.class, ()
+        -> {


what happened here? XD

(() -> hiveDefaultName.createDatabase(hiveDefaultName.databaseName())); could be on this line)

AnanaMJ · 2019-08-22T08:38:26Z

src/test/java/com/hotels/beeju/extensions/HiveMetaStoreJUnitExtensionTest.java

-    Assertions.assertThrows(AlreadyExistsException.class, () -> {
-      hiveDefaultName.createDatabase(hiveDefaultName.databaseName());
-    });
+    Assertions.assertThrows(AlreadyExistsException.class, () -> hiveDefaultName.createDatabase(hiveDefaultName.databaseName()));


this is probably supposed to be on 2 lines (over 120 characters :( )

you are correct :')

pom.xml

massdosage · 2019-08-28T16:11:18Z

README.md


 [![Maven Central](https://maven-badges.herokuapp.com/maven-central/com.hotels/beeju/badge.svg?subject=com.hotels:beeju)](https://maven-badges.herokuapp.com/maven-central/com.hotels/beeju) [![Build Status](https://travis-ci.org/HotelsDotCom/beeju.svg?branch=master)](https://travis-ci.org/HotelsDotCom/beeju) [![Coverage Status](https://coveralls.io/repos/github/HotelsDotCom/beeju/badge.svg?branch=master)](https://coveralls.io/github/HotelsDotCom/beeju) ![GitHub license](https://img.shields.io/github/license/HotelsDotCom/beeju.svg)

 # Overview
-BeeJU provides [JUnit rules](http://junit.org/junit4/javadoc/4.12/org/junit/Rule.html) that can be used to write test code that tests [Hive](https://hive.apache.org/). A JUnit rule is a means to provide resources in a test and automatically tear them down when the life cycle of a test ends.
+BeeJU provides [JUnit4 rules](http://junit.org/junit4/javadoc/4.12/org/junit/Rule.html) that can be used to write test code that tests [Hive](https://hive.apache.org/). A JUnit rule is a means to provide resources in a test and automatically tear them down when the life cycle of a test ends.


Let's switch this around and call out JUnit5 first as this is the preferred way going forward. So.. "BeeJU provides JUnit5 Extensions... etc." and then "BeeJU also provides JUnit4 rules" etc.

massdosage · 2019-08-28T16:12:33Z

README.md


-### JUnit5
-For JUnit5, support is available to enable you to migrate your tests that currently use Beeju rules. To use JUnit5, ensure you have:
+### JUnit5 Rule Migration


Maybe redo this and have JUnit5 documented first with just examples of the extensions and then a separate section afterwards for JUnit4 which just has the rules. I know this has more repeated code but for readers they can just look at one section and don't have to think about whether they're doing a rule or an extension.

pom.xml

src/main/java/com/hotels/beeju/BeejuJUnitRule.java

src/test/java/com/hotels/beeju/extensions/HiveMetaStoreJUnitExtensionTest.java

massdosage · 2019-08-28T16:29:17Z

src/test/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtensionTest.java

+
+public class ThriftHiveMetaStoreJUnitExtensionTest implements BeforeEachCallback {
+
+  private static File defaultTempRoot;


Is there a reason for these two being static? If not we generally favour not using static (for various reasons we can go into).

The temp folders aren't actually needed anymore for these tests either so I'll remove them, but happy to learn more about static vs non-static :D

src/test/java/com/hotels/beeju/extensions/ThriftHiveMetaStoreJUnitExtensionTest.java

massdosage · 2019-08-30T14:14:58Z

README.md

-BeeJU provides [JUnit rules](http://junit.org/junit4/javadoc/4.12/org/junit/Rule.html) that can be used to write test code that tests [Hive](https://hive.apache.org/). A JUnit rule is a means to provide resources in a test and automatically tear them down when the life cycle of a test ends.
-This project is currently built with and tested against Hive 2.3.0 (and minor versions back to Hive 1.2.1) but is most likely compatible with older and newer versions of Hive. The available JUnit rules are explained in more detail below.  
+BeeJU provides [JUnit5 Extensions](https://junit.org/junit5/docs/current/user-guide/#extensions) that can be used to write test code that tests [Hive](https://hive.apache.org/). The JUnit lifecycle extension points are a means to provide resources in a test and automatically tear them down when the life cycle of a test ends.
+This project is currently built with and tested against Hive 2.3.0 (and minor versions back to Hive 1.2.1) but is most likely compatible with older and newer versions of Hive. The available JUnit extensions are explained in more detail below.  


2.3.0 -> 2.3.x
(not your fault this out of date but might as well fix it now)

massdosage · 2019-08-30T14:15:35Z

CHANGELOG.md

+- JDK version upgrade to 1.8 (was 1.7).
+
+### Added
+- JUnit5 extension class equivalents for all Beeju Rules. 


Beeju -> BeeJU
(can you do find and replace on this in the while file plz)

massdosage · 2019-08-30T14:18:36Z

README.md

 # Usage
-The BeeJU JUnit rules provide a way to run tests that have an underlying requirement to use the Hive Metastore API but don't have the ability to mock the [Hive Metastore Client](https://hive.apache.org/javadocs/r1.2.1/api/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.html). The rules spin up and tear down an in-memory Metastore which may add few seconds to the test life cycle so if you require tests to run in the sub-second range this is not for you.
+The BeeJU JUnit rules and extensions provide a way to run tests that have an underlying requirement to use the Hive Metastore API but don't have the ability to mock the [Hive Metastore Client](https://hive.apache.org/javadocs/r1.2.1/api/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.html). The rules and extensions spin up and tear down an in-memory Metastore which may add a few seconds to the test life cycle so if you require tests to run in the sub-second range this is not for you. 


While we're fixing the outdated things, can you please update the javadoc link to https://hive.apache.org/javadocs/r2.3.6/api/index.html (I couldn't find javadoc for 2.3.4).

README.md

src/main/java/com/hotels/beeju/BeejuJUnitRule.java

src/main/java/com/hotels/beeju/core/BeejuCore.java

massdosage · 2019-08-30T14:26:31Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+
+import com.hotels.beeju.core.BeejuCore;
+
+abstract public class BeejuJUnitExtension implements BeforeEachCallback, AfterEachCallback {


switch public and abstract around (that's our convention to have access level first, granted we don't document this anywhere so it needs to be filed under "tribal knowledge")

massdosage · 2019-08-30T14:27:34Z

src/main/java/com/hotels/beeju/extensions/BeejuJUnitExtension.java

+
+abstract public class BeejuJUnitExtension implements BeforeEachCallback, AfterEachCallback {
+
+  public BeejuCore core;


Can't this be made private?

In the 3 classes we extend from BeejuJUnitExtension we have to pass the core object we've created into the next layer core class e.g. to create the HiveServer2Core object you need the BeejuCore object that we create here so I don't think this can be private

But i shall make it protected!

src/test/java/com/hotels/beeju/extensions/HiveMetaStoreJUnitExtensionTest.java

…xtensions # Conflicts: # CHANGELOG.md

cmathiesen added 2 commits August 12, 2019 14:26

Added extension classes for all the rules along with tests

6312d8e

Update travis

a533d51

cmathiesen requested review from massdosage and patduin and removed request for massdosage August 12, 2019 13:35

Update javadoc and readme

8434170

patduin requested changes Aug 12, 2019

View reviewed changes

cmathiesen added 2 commits August 15, 2019 10:57

Javadoc update and temporary folder moved to core logic

3818a09

Move temp folder to core logic, move HiveServer2 tests into core classes

549af6f

cmathiesen marked this pull request as ready for review August 16, 2019 10:33

cmathiesen requested a review from AnanaMJ August 16, 2019 10:34

Fix tests

8bee50f

AnanaMJ reviewed Aug 16, 2019

View reviewed changes

patduin reviewed Aug 19, 2019

View reviewed changes

patduin requested changes Aug 19, 2019

View reviewed changes

abhimanyugupta07 reviewed Aug 19, 2019

View reviewed changes

src/test/java/com/hotels/beeju/core/HiveServer2CoreTest.java Outdated Show resolved Hide resolved

src/test/java/com/hotels/beeju/extensions/HiveServer2JUnitExtensionTest.java Outdated Show resolved Hide resolved

patduin reviewed Aug 19, 2019

View reviewed changes

src/main/java/com/hotels/beeju/HiveMetaStoreJUnitRule.java Outdated Show resolved Hide resolved

Clean up code

8afd644

patduin approved these changes Aug 21, 2019

View reviewed changes

abhimanyugupta07 approved these changes Aug 21, 2019

View reviewed changes

AnanaMJ reviewed Aug 22, 2019

View reviewed changes

cmathiesen added 2 commits August 22, 2019 09:32

Clean up

511dd84

Correct version

224ba5e

AnanaMJ reviewed Aug 22, 2019

View reviewed changes

Clean up

fd805ed

AnanaMJ approved these changes Aug 22, 2019

View reviewed changes

massdosage suggested changes Aug 28, 2019

View reviewed changes

cmathiesen and others added 3 commits August 30, 2019 09:39

Refactor and clean up

f6b9b3e

Update readme and changelog

81fe8e3

Merge branch 'master' into junit5-extensions

0c3294e

massdosage suggested changes Aug 30, 2019

View reviewed changes

cmathiesen and others added 5 commits August 30, 2019 16:35

Clean up

74ee491

Merge remote-tracking branch 'origin/junit5-extensions' into junit5-e…

e8c46c8

…xtensions # Conflicts: # CHANGELOG.md

Merge branch 'master' into junit5-extensions

3e9ec66

Merge branch 'master' into junit5-extensions

c207a74

Fix readme

f4c7901

massdosage approved these changes Sep 2, 2019

View reviewed changes

massdosage merged commit 28f4656 into master Sep 2, 2019

massdosage deleted the junit5-extensions branch September 2, 2019 10:48


		Database database = hive.client().getDatabase(databaseName);

		assertThat(database.getName(), is(databaseName));


		public class BeejuCore {

		private static final Logger LOG = LoggerFactory.getLogger(BeejuCore.class);


		public class ThriftHiveMetaStoreJUnitExtensionTest implements BeforeEachCallback {

		private static File defaultTempRoot;


		import com.hotels.beeju.core.BeejuCore;

		abstract public class BeejuJUnitExtension implements BeforeEachCallback, AfterEachCallback {


		abstract public class BeejuJUnitExtension implements BeforeEachCallback, AfterEachCallback {

		public BeejuCore core;

JUnit5 extension classes #28

JUnit5 extension classes #28

Conversation

cmathiesen commented Aug 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Aug 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmathiesen Aug 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhimanyugupta07 left a comment

Choose a reason for hiding this comment

patduin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmathiesen commented Aug 12, 2019 •

edited

Loading

coveralls commented Aug 14, 2019 •

edited

Loading

cmathiesen Aug 19, 2019 •

edited

Loading