Update codeql-analysis.yml #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove HEAD^2
massdosage
commented
Mar 4, 2021
| @@ -19,11 +19,11 @@ jobs: | |||
| # a pull request then we can checkout the head. | |||
| fetch-depth: 2 | |||
|
|
|||
| # If this run was triggered by a pull request event, then checkout | |||
There was a problem hiding this comment.
This has nothing to do with the Java version but I noticed this warning in the build while checking this so I figured I would remove it:
issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results.
patduin
approved these changes
Mar 4, 2021
JayGreeeen
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodeQL GitHub action is failing as its decided to start using Java 11 instead of 8 (probably due to some change in
ubuntu-latest) and WaggleDance doesn't build on Java 11. So this change sets the Java version to 8.