Skip to content

Commit

Permalink
Merge pull request #50336 from cretadn22/display-approver-name-instea…
Browse files Browse the repository at this point in the history
…d-of-email
  • Loading branch information
francoisl authored Oct 7, 2024
2 parents 1c25885 + dab577d commit 08becfd
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/pages/workspace/categories/CategorySettingsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import * as CategoryUtils from '@libs/CategoryUtils';
import * as CurrencyUtils from '@libs/CurrencyUtils';
import * as ErrorUtils from '@libs/ErrorUtils';
import Navigation from '@libs/Navigation/Navigation';
import * as PersonalDetailsUtils from '@libs/PersonalDetailsUtils';
import {isControlPolicy} from '@libs/PolicyUtils';
import * as PolicyUtils from '@libs/PolicyUtils';
import type {SettingsNavigatorParamList} from '@navigation/types';
Expand Down Expand Up @@ -77,8 +78,9 @@ function CategorySettingsPage({
}, [policyCategory?.maxExpenseAmount, policyCategoryExpenseLimitType, policyCurrency, translate]);

const approverText = useMemo(() => {
const categoryApprover = CategoryUtils.getCategoryApproverRule(policy?.rules?.approvalRules ?? [], categoryName)?.approver;
return categoryApprover ?? '';
const categoryApprover = CategoryUtils.getCategoryApproverRule(policy?.rules?.approvalRules ?? [], categoryName)?.approver ?? '';
const approver = PersonalDetailsUtils.getPersonalDetailByEmail(categoryApprover);
return approver?.displayName ?? categoryApprover;
}, [categoryName, policy?.rules?.approvalRules]);

const defaultTaxRateText = useMemo(() => {
Expand Down

0 comments on commit 08becfd

Please sign in to comment.