use global vars

Expensify · Apr 19, 2024 · 188b68d · 188b68d
1 parent 1f2abbd
commit 188b68d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.github/scripts/detectRedirectCycle.ts b/.github/scripts/detectRedirectCycle.ts
@@ -2,7 +2,10 @@ import {parse} from 'csv-parse';
 import fs from 'fs';
 
 const parser = parse();
+
 const adjacencyList: Record<string, string[]> = {};
+const visited: Map<string, boolean> = new Map<string, boolean>();
+const backEdges: Map<string, boolean> = new Map<string, boolean>();
 
 function addEdge(source: string, target: string) {
     if (!adjacencyList[source]) {
@@ -11,7 +14,7 @@ function addEdge(source: string, target: string) {
     adjacencyList[source].push(target);
 }
 
-function isCyclic(currentNode: string, visited: Map<string, boolean>, backEdges: Map<string, boolean>): boolean {
+function isCyclic(currentNode: string): boolean {
     visited.set(currentNode, true);
     backEdges.set(currentNode, true);
 
@@ -20,7 +23,7 @@ function isCyclic(currentNode: string, visited: Map<string, boolean>, backEdges:
     if (neighbours) {
         for (const node of neighbours) {
             if (!visited.has(node)) {
-                if (isCyclic(node, visited, backEdges)) {
+                if (isCyclic(node)) {
                     return true;
                 }
             } else if (backEdges.has(node)) {
@@ -35,12 +38,9 @@ function isCyclic(currentNode: string, visited: Map<string, boolean>, backEdges:
 }
 
 function detectCycle(): boolean {
-    const visited: Map<string, boolean> = new Map<string, boolean>();
-    const backEdges: Map<string, boolean> = new Map<string, boolean>();
-
     for (const [node] of Object.entries(adjacencyList)) {
         if (!visited.has(node)) {
-            if (isCyclic(node, visited, backEdges)) {
+            if (isCyclic(node)) {
                 const cycle = Array.from(backEdges.keys());
                 console.log(`Infinite redirect found in the cycle: ${cycle.join(' -> ')} -> ${node}`);
                 return true;

diff --git a/docs/redirects.csv b/docs/redirects.csv
@@ -87,6 +87,7 @@ https://help.expensify.com/articles/new-expensify/payments/Request-Money,https:/
 https://help.expensify.com/articles/expensify-classic/workspace-and-domain-settings/tax-tracking,https://help.expensify.com/articles/expensify-classic/expenses/expenses/Apply-Tax
 https://help.expensify.com/articles/expensify-classic/copilots-and-delegates/User-Roles.html,https://help.expensify.com/expensify-classic/hubs/copilots-and-delegates/
 https://help.expensify.com/articles/expensify-classic/expensify-billing/Billing-Owner,https://help.expensify.com/articles/expensify-classic/workspaces/Assign-billing-owner-and-payment-account
+https://help.expensify.com/articles/expensify-classic/expensify-billing/Billing-Owner.html,https://help.expensify.com/articles/expensify-classic/workspaces/Assign-billing-owner-and-payment-account
 https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Other-Export-Options.html,https://help.expensify.com/articles/expensify-classic/spending-insights/Other-Export-Options
 https://help.expensify.com/articles/expensify-classic/bank-accounts-and-credit-cards/business-bank-accounts/Business-Bank-Accounts-AUD,https://help.expensify.com/articles/expensify-classic/connect-credit-cards/Global-Reimbursements
 https://help.expensify.com/expensify-classic/hubs/bank-accounts-and-credit-cards,https://help.expensify.com/expensify-classic/hubs/