Merge pull request #4810 from parasharrajat/locale-pick

fix Locale Picker and small picker styles

src/components/Picker/index.js

@@ -28,6 +28,10 @@ const Picker = ({
         fixAndroidTouchableBug
         onOpen={onOpen}
         onClose={onClose}
+        pickerProps={{
+            onFocus: onOpen,
+            onBlur: onClose,
+        }}
     />
 );
 

src/components/Picker/pickerStyles/index.js

@@ -1,5 +1,22 @@
+import CONST from '../../../CONST';
+import getBrowser from '../../../libs/getBrowser';
 import styles from '../../../styles/styles';
 
-const pickerStyles = disabled => styles.expensiPicker(disabled);
+const pickerStylesWeb = () => {
+    if (CONST.BROWSER.FIREFOX === getBrowser()) {
+        return {
+            textIndent: -2,
+        };
+    }
+    return {};
+};
+
+const pickerStyles = disabled => ({
+    ...styles.expensiPicker(disabled),
+    inputWeb: {
+        ...styles.expensiPicker(disabled).inputWeb,
+        ...pickerStylesWeb(),
+    },
+});
 
 export default pickerStyles;

src/libs/actions/App.js

@@ -36,7 +36,9 @@ function setCurrentURL(url) {
 * @param {String} locale
 */
 function setLocale(locale) {
-    API.PreferredLocale_Update({name: 'preferredLocale', value: locale});
+    if (currentUserAccountID) {
+        API.PreferredLocale_Update({name: 'preferredLocale', value: locale});
+    }
     Onyx.merge(ONYXKEYS.NVP_PREFERRED_LOCALE, locale);
 }
 

src/libs/getBrowser/index.js

@@ -0,0 +1 @@
+export default () => '';

src/libs/getBrowser/index.web.js

@@ -0,0 +1,42 @@
+import CONST from '../../CONST';
+
+/**
+ * Fetch browser name from UA string
+ *
+ * @return {String} e.g. Chrome
+ */
+function getBrowser() {
+    const {userAgent} = window.navigator;
+    let match = userAgent.match(/(opera|chrome|safari|firefox|msie|trident(?=\/))/i) || [];
+    let temp;
+
+    if (/trident/i.test(match[1])) {
+        return 'IE';
+    }
+
+    if (match[1] && (match[1].toLowerCase() === 'chrome')) {
+        temp = userAgent.match(/\b(OPR|Edge)\/(\d+)/);
+
+        if (temp !== null) {
+            return temp.slice(1).replace('OPR', 'Opera');
+        }
+
+        temp = userAgent.match(/\b(Edg)\/(\d+)/);
+
+        if (temp !== null) {
+            return temp.slice(1).replace('Edg', 'Edge');
+        }
+    }
+
+    match = match[1] ? match[1] : navigator.appName;
+    return match;
+}
+
+/**
+ * Get the Browser name
+ * @returns {String}
+ */
+export default () => {
+    const browser = getBrowser();
+    return browser ? browser.toLowerCase() : CONST.BROWSER.OTHER;
+};

src/styles/styles.js

@@ -372,6 +372,7 @@ const styles = {
             borderRadius: variables.componentBorderRadius,
             borderWidth: 1,
             borderColor: themeColors.border,
+            borderStyle: 'solid',
             color: themeColors.text,
             height: variables.componentSizeSmall,
             opacity: 1,
@@ -387,6 +388,7 @@ const styles = {
             borderWidth: 1,
             borderRadius: variables.componentBorderRadius,
             borderColor: themeColors.border,
+            borderStyle: 'solid',
             color: themeColors.text,
             appearance: 'none',
             height: variables.componentSizeSmall,
@@ -404,6 +406,7 @@ const styles = {
             borderWidth: 1,
             borderRadius: variables.componentBorderRadius,
             borderColor: themeColors.border,
+            borderStyle: 'solid',
             color: themeColors.text,
             height: variables.componentSizeSmall,
             opacity: 1,