cleanup function and update comment

Expensify · Mar 26, 2024 · 1f8265c · 1f8265c
1 parent 5f3f51c
commit 1f8265c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/EmojiPicker/EmojiPickerMenu/useEmojiPickerMenu.js b/src/components/EmojiPicker/EmojiPickerMenu/useEmojiPickerMenu.js
@@ -24,7 +24,11 @@ const useEmojiPickerMenu = () => {
     const [preferredSkinTone] = usePreferredEmojiSkinTone();
     const {windowHeight} = useWindowDimensions();
     const StyleUtils = useStyleUtils();
-    // calculate the height of the emoji picker based popoverInnerContainer style has maxHeight is 95%
+    /**
+     * At EmojiPicker has set innerContainerStyle with maxHeight: '95%' by styles.popoverInnerContainer
+     * to avoid the list style to be cut off due to the list height being larger than the container height
+     * so we need to calculate listStyle based on the height of the window and innerContainerStyle at the EmojiPicker
+     */
     const listStyle = StyleUtils.getEmojiPickerListHeight(isListFiltered, windowHeight * 0.95);
 
     useEffect(() => {

diff --git a/src/hooks/useViewportOffsetTop/index.ts b/src/hooks/useViewportOffsetTop/index.ts
@@ -33,11 +33,7 @@ export default function useViewportOffsetTop(shouldAdjustScrollView = false): nu
             }
         };
         updateOffsetTop();
-        const removeViewportResizeListener = addViewportResizeListener(updateOffsetTop);
-
-        return () => {
-            removeViewportResizeListener();
-        };
+        return addViewportResizeListener(updateOffsetTop);
     }, [initialHeight, shouldAdjustScrollView]);
 
     useEffect(() => {