Skip to content

Commit

Permalink
Merge pull request #15610 from bernhardoj/fix/15284
Browse files Browse the repository at this point in the history
synchronize composer text between tabs
  • Loading branch information
cristipaval authored Mar 6, 2023
2 parents a7c196f + c8d3dcb commit 228a29b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/pages/home/report/ReportActionCompose.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,13 @@ class ReportActionCompose extends React.Component {
this.setMaxLines();
}

// Value state does not have the same value as comment props when the comment gets changed from another tab.
// In this case, we should synchronize the value between tabs.
const shouldSyncComment = prevProps.comment !== this.props.comment && this.state.value !== this.props.comment;

// As the report IDs change, make sure to update the composer comment as we need to make sure
// we do not show incorrect data in there (ie. draft of message from other report).
if (this.props.report.reportID === prevProps.report.reportID) {
if (this.props.report.reportID === prevProps.report.reportID && !shouldSyncComment) {
return;
}

Expand Down

0 comments on commit 228a29b

Please sign in to comment.