Skip to content

Commit

Permalink
Remove viewing search query in the list and add bookmark icon for mobile
Browse files Browse the repository at this point in the history
  • Loading branch information
mkzie2 committed Sep 23, 2024
1 parent 5e106f0 commit 299040a
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions src/pages/Search/SearchTypeMenuNarrow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,20 +84,6 @@ function SearchTypeMenuNarrow({typeMenuItems, activeItemIndex, queryJSON, title,
};
});

if (title) {
items.push({
text: title,
onSelected: closeMenu,
isSelected: !currentSavedSearch,
icon: Expensicons.Filters,
iconFill: theme.iconSuccessFill,
success: true,
containerStyle: undefined,
iconRight: Expensicons.Checkmark,
shouldShowRightIcon: false,
});
}

return items;
}, [typeMenuItems, activeItemIndex, title, theme, singleExecution, closeMenu, currentSavedSearch]);

Check warning on line 88 in src/pages/Search/SearchTypeMenuNarrow.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

React Hook useMemo has unnecessary dependencies: 'closeMenu' and 'currentSavedSearch'. Either exclude them or remove the dependency array

Check warning on line 88 in src/pages/Search/SearchTypeMenuNarrow.tsx

View workflow job for this annotation

GitHub Actions / ESLint check

React Hook useMemo has unnecessary dependencies: 'closeMenu' and 'currentSavedSearch'. Either exclude them or remove the dependency array

Expand All @@ -109,6 +95,7 @@ function SearchTypeMenuNarrow({typeMenuItems, activeItemIndex, queryJSON, title,
text: item.title ?? '',
styles: [styles.textSupporting],
onSelected: item.onPress,
icon: Expensicons.Bookmark,
shouldShowRightComponent: true,
rightComponent: (
<ThreeDotsMenu
Expand Down

0 comments on commit 299040a

Please sign in to comment.