Skip to content

Commit

Permalink
Merge pull request #48860 from Expensify/Rory-ImproveNodeCacheHitRate
Browse files Browse the repository at this point in the history
[No QA] Improve cache hit rate of setup-node by ignoring E/App version
  • Loading branch information
aldo-expensify authored Sep 10, 2024
2 parents f642361 + f8b589a commit 45be2e9
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/actions/composite/setupNode/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@ outputs:
runs:
using: composite
steps:
- name: Remove E/App version from package-lock.json
shell: bash
run: jq 'del(.version, .packages[""].version)' package-lock.json > normalized-package-lock.json

- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: npm
cache-dependency-path: |
package-lock.json
normalized-package-lock.json
desktop/package-lock.json
- id: cache-node-modules
Expand Down

0 comments on commit 45be2e9

Please sign in to comment.