Merge pull request #48654 from margelo/chore/fix-timing-measurement

[NoQA] fix: timing measurements are inaccurate

src/libs/actions/Timing.ts

@@ -20,13 +20,11 @@ let timestampData: Record<string, TimestampData> = {};
  * @param shouldUseFirebase - adds an additional trace in Firebase
  */
 function start(eventName: string, shouldUseFirebase = true) {
-    timestampData[eventName] = {startTime: Date.now(), shouldUseFirebase};
-
-    if (!shouldUseFirebase) {
-        return;
+    if (shouldUseFirebase) {
+        Firebase.startTrace(eventName);
     }
 
-    Firebase.startTrace(eventName);
+    timestampData[eventName] = {startTime: performance.now(), shouldUseFirebase};
 }
 
 /**
@@ -42,13 +40,14 @@ function end(eventName: string, secondaryName = '', maxExecutionTime = 0) {
     }
 
     const {startTime, shouldUseFirebase} = timestampData[eventName];
-    Environment.getEnvironment().then((envName) => {
-        const eventTime = Date.now() - startTime;
 
-        if (shouldUseFirebase) {
-            Firebase.stopTrace(eventName);
-        }
+    const eventTime = performance.now() - startTime;
 
+    if (shouldUseFirebase) {
+        Firebase.stopTrace(eventName);
+    }
+
+    Environment.getEnvironment().then((envName) => {
         const baseEventName = `${envName}.new.expensify.${eventName}`;
         const grafanaEventName = secondaryName ? `${baseEventName}.${secondaryName}` : baseEventName;