Skip to content

Commit

Permalink
Merge branch 'main' into ts/eslint-typescript-config
Browse files Browse the repository at this point in the history
  • Loading branch information
blazejkustra committed May 13, 2024
2 parents 7f6763c + cf14505 commit 6f2f703
Show file tree
Hide file tree
Showing 44 changed files with 545 additions and 1,674 deletions.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001047201
versionName "1.4.72-1"
versionCode 1001047300
versionName "1.4.73-0"
// Supported language variants must be declared here to avoid from being removed during the compilation.
// This also helps us to not include unnecessary language variants in the APK.
resConfigs "en", "es"
Expand Down
92 changes: 0 additions & 92 deletions docs/articles/new-expensify/settings/Profile.md

This file was deleted.

6 changes: 6 additions & 0 deletions docs/articles/new-expensify/workspaces/Coming-Soon.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: Coming Soon!
description: More info coming soon!
---

<!-- The lines above are required by Jekyll to process the .md file -->
149 changes: 0 additions & 149 deletions docs/articles/new-expensify/workspaces/The-Free-Plan.md

This file was deleted.

4 changes: 2 additions & 2 deletions ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.4.72</string>
<string>1.4.73</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand All @@ -40,7 +40,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.4.72.1</string>
<string>1.4.73.0</string>
<key>FullStory</key>
<dict>
<key>OrgId</key>
Expand Down
4 changes: 2 additions & 2 deletions ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<key>CFBundlePackageType</key>
<string>BNDL</string>
<key>CFBundleShortVersionString</key>
<string>1.4.72</string>
<string>1.4.73</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.4.72.1</string>
<string>1.4.73.0</string>
</dict>
</plist>
4 changes: 2 additions & 2 deletions ios/NotificationServiceExtension/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundleShortVersionString</key>
<string>1.4.72</string>
<string>1.4.73</string>
<key>CFBundleVersion</key>
<string>1.4.72.1</string>
<string>1.4.73.0</string>
<key>NSExtension</key>
<dict>
<key>NSExtensionPointIdentifier</key>
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "new.expensify",
"version": "1.4.72-1",
"version": "1.4.73-0",
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
2 changes: 1 addition & 1 deletion src/CONST.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1954,7 +1954,7 @@ const CONST = {

POLICY_ID_FROM_PATH: /\/w\/([a-zA-Z0-9]+)(\/|$)/,

SHORT_MENTION: new RegExp(`@[\\w\\-\\+\\'#@]+(?:\\.[\\w\\-\\'\\+]+)*`, 'gim'),
SHORT_MENTION: new RegExp(`@[\\w\\-\\+\\'#@]+(?:\\.[\\w\\-\\'\\+]+)*(?![^\`]*\`)`, 'gim'),
},

PRONOUNS: {
Expand Down
26 changes: 2 additions & 24 deletions src/components/AttachmentModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,6 @@ import SafeAreaConsumer from './SafeAreaConsumer';
type AttachmentModalOnyxProps = {
/** The transaction associated with the receipt attachment, if any */
transaction: OnyxEntry<OnyxTypes.Transaction>;

/** The report associated with the receipt attachment, if any */
parentReport: OnyxEntry<OnyxTypes.Report>;

/** The policy associated with the receipt attachment, if any */
policy: OnyxEntry<OnyxTypes.Policy>;

/** The list of report actions associated with the receipt attachment, if any */
parentReportActions: OnyxEntry<OnyxTypes.ReportActions>;
};

type ImagePickerResponse = {
Expand Down Expand Up @@ -157,10 +148,7 @@ function AttachmentModal({
isWorkspaceAvatar = false,
maybeIcon = false,
transaction,
parentReport,
parentReportActions,
headerTitle,
policy,
children,
fallbackSource,
canEditReceipt = false,
Expand Down Expand Up @@ -413,7 +401,7 @@ function AttachmentModal({
const sourceForAttachmentView = sourceState || source;

const threeDotsMenuItems = useMemo(() => {
if (!isReceiptAttachment || !parentReport || !parentReportActions) {
if (!isReceiptAttachment) {
return [];
}

Expand Down Expand Up @@ -454,7 +442,7 @@ function AttachmentModal({
}
return menuItems;
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [isReceiptAttachment, parentReport, parentReportActions, policy, transaction, file, sourceState, iouType]);
}, [isReceiptAttachment, transaction, file, sourceState, iouType]);

// There are a few things that shouldn't be set until we absolutely know if the file is a receipt or an attachment.
// props.isReceiptAttachment will be null until its certain what the file is, in which case it will then be true|false.
Expand Down Expand Up @@ -621,16 +609,6 @@ export default withOnyx<AttachmentModalProps, AttachmentModalOnyxProps>({
},
initWithStoredValues: false,
},
parentReport: {
key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT}${report ? report.parentReportID : '0'}`,
},
policy: {
key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report ? report.policyID : '0'}`,
},
parentReportActions: {
key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '0'}`,
canEvict: false,
},
})(memo(AttachmentModal));

export type {Attachment, FileObject, ImagePickerResponse};
Loading

0 comments on commit 6f2f703

Please sign in to comment.