-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #46234 from Expensify/dangrous-refactorupdatepolic…
…yconnectionconfig1 Refactor UpdatePolicyConnectionConfiguration to be 1:1:1 (Part 1)
- Loading branch information
Showing
10 changed files
with
277 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/libs/API/parameters/UpdateQuickbooksOnlineGenericTypeParams.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| type UpdateQuickbooksOnlineGenericTypeParams = { | ||
| policyID: string; | ||
| settingValue: string; | ||
| idempotencyKey: string; | ||
| }; | ||
|
|
||
| export default UpdateQuickbooksOnlineGenericTypeParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,252 @@ | ||
| import type {OnyxUpdate} from 'react-native-onyx'; | ||
| import Onyx from 'react-native-onyx'; | ||
| import * as API from '@libs/API'; | ||
| import type {ConnectPolicyToAccountingIntegrationParams} from '@libs/API/parameters'; | ||
| import type UpdateQuickbooksOnlineGenericTypeParams from '@libs/API/parameters/UpdateQuickbooksOnlineGenericTypeParams'; | ||
| import {READ_COMMANDS, WRITE_COMMANDS} from '@libs/API/types'; | ||
| import {getCommandURL} from '@libs/ApiUtils'; | ||
| import * as ErrorUtils from '@libs/ErrorUtils'; | ||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type {ConnectionName, Connections} from '@src/types/onyx/Policy'; | ||
|
|
||
| type ConnectionNameExceptNetSuite = Exclude<ConnectionName, typeof CONST.POLICY.CONNECTIONS.NAME.NETSUITE>; | ||
|
|
||
| function getQuickbooksOnlineSetupLink(policyID: string) { | ||
| const params: ConnectPolicyToAccountingIntegrationParams = {policyID}; | ||
| const commandURL = getCommandURL({ | ||
| command: READ_COMMANDS.CONNECT_POLICY_TO_QUICKBOOKS_ONLINE, | ||
| shouldSkipWebProxy: true, | ||
| }); | ||
| return commandURL + new URLSearchParams(params).toString(); | ||
| } | ||
|
|
||
| function updateQuickbooksOnlineEnableNewCategories(policyID: string, settingValue: boolean) { | ||
| const optimisticData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: null, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const failureData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: null, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const successData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: null, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES]: null, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const parameters: UpdateQuickbooksOnlineGenericTypeParams = { | ||
| policyID, | ||
| settingValue: JSON.stringify(settingValue), | ||
| idempotencyKey: String(CONST.QUICK_BOOKS_CONFIG.ENABLE_NEW_CATEGORIES), | ||
| }; | ||
| API.write(WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_ENABLE_NEW_CATEGORIES, parameters, {optimisticData, failureData, successData}); | ||
| } | ||
|
|
||
| function updateQuickbooksOnlineAutoCreateVendor(policyID: string, settingValue: boolean) { | ||
| const optimisticData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: null, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const failureData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: null, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const successData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: null, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: null, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const parameters: UpdateQuickbooksOnlineGenericTypeParams = { | ||
| policyID, | ||
| settingValue: JSON.stringify(settingValue), | ||
| idempotencyKey: String(CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR), | ||
| }; | ||
| API.write(WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_AUTO_CREATE_VENDOR, parameters, {optimisticData, failureData, successData}); | ||
| } | ||
|
|
||
| function updateQuickbooksOnlineReimbursableExpensesAccount<TConnectionName extends ConnectionNameExceptNetSuite, TSettingName extends keyof Connections[TConnectionName]['config']>( | ||
| policyID: string, | ||
| settingValue: Partial<Connections[TConnectionName]['config'][TSettingName]>, | ||
| ) { | ||
| const optimisticData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: null, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const failureData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: null, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const successData: OnyxUpdate[] = [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, | ||
| value: { | ||
| connections: { | ||
| [CONST.POLICY.CONNECTIONS.NAME.QBO]: { | ||
| config: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: settingValue ?? null, | ||
| pendingFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: null, | ||
| }, | ||
| errorFields: { | ||
| [CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT]: null, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const parameters: UpdateQuickbooksOnlineGenericTypeParams = { | ||
| policyID, | ||
| settingValue: JSON.stringify(settingValue), | ||
| idempotencyKey: String(CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT), | ||
| }; | ||
| API.write(WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_REIMBURSABLE_EXPENSES_ACCOUNT, parameters, {optimisticData, failureData, successData}); | ||
| } | ||
|
|
||
| export {getQuickbooksOnlineSetupLink, updateQuickbooksOnlineEnableNewCategories, updateQuickbooksOnlineAutoCreateVendor, updateQuickbooksOnlineReimbursableExpensesAccount}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.