Merge pull request #8639 from Expensify/marcaaron-betterLoggingForAut…

…henticateFailures [No QA] Stop sending `undefined` request params to the API
Expensify · Apr 18, 2022 · 8908393 · 8908393
2 parents 88a03ff + d3bc627
commit 8908393
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/libs/HttpUtils.js b/src/libs/HttpUtils.js
@@ -49,7 +49,14 @@ function processHTTPRequest(url, method = 'get', body = null, canCancel = true)
  */
 function xhr(command, data, type = CONST.NETWORK.METHOD.POST, shouldUseSecure = false) {
     const formData = new FormData();
-    _.each(data, (val, key) => formData.append(key, val));
+    _.each(data, (val, key) => {
+        // Do not send undefined request parameters to our API. They will be processed as strings of 'undefined'.
+        if (_.isUndefined(val)) {
+            return;
+        }
+
+        formData.append(key, val);
+    });
     let apiRoot = shouldUseSecure ? CONFIG.EXPENSIFY.SECURE_EXPENSIFY_URL : CONFIG.EXPENSIFY.URL_API_ROOT;
 
     if (shouldUseSecure && shouldUseSecureStaging) {