Remove setup-mapbox from setupNode

Expensify · Aug 22, 2023 · ad31b02 · ad31b02
1 parent 120bcbf
commit ad31b02
Show file tree

Hide file tree

Showing 13 changed files with 1 addition and 50 deletions.
diff --git a/.github/actions/composite/buildAndroidAPK/action.yml b/.github/actions/composite/buildAndroidAPK/action.yml
@@ -13,8 +13,6 @@ runs:
   using: composite
   steps:
     - uses: Expensify/App/.github/actions/composite/setupNode@main
-      with:
-        MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ inputs.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
     - uses: ruby/setup-ruby@eae47962baca661befdfd24e4d6c34ade04858f7
       with:

diff --git a/.github/actions/composite/setupNode/action.yml b/.github/actions/composite/setupNode/action.yml
@@ -1,11 +1,6 @@
 name: Set up Node
 description: Set up Node
 
-inputs:
-  MAPBOX_SDK_DOWNLOAD_TOKEN:
-    description: Download token for the closed-source MapBox SDK.
-    required: true
-
 runs:
   using: composite
   steps:
@@ -29,10 +24,6 @@ runs:
         path: desktop/node_modules
         key: ${{ runner.os }}-desktop-node-modules-${{ hashFiles('desktop/package-lock.json') }}
 
-    - name: Configure MapBox credentials to install closed-source SDK
-      run: ./scripts/setup-mapbox-sdk.sh ${{ inputs.MAPBOX_SDK_DOWNLOAD_TOKEN }}
-      shell: bash
-
     - name: Install root project node packages
       if: steps.cache-node-modules.outputs.cache-hit != 'true'
       uses: nick-fields/retry@v2

diff --git a/.github/workflows/README.md b/.github/workflows/README.md
@@ -149,4 +149,4 @@ In order to bundle actions with their dependencies into a single Node.js executa
        Do not try to use a relative path.
 - Confusingly, paths in action metadata files (`action.yml`) _must_ use relative paths.
 - You can't use any dynamic values or environment variables in a `uses` statement
-- In general, it is a best practice to minimize any side-effects of each action. Using atomic ("dumb") actions that have a clear and simple purpose will promote reuse and make it easier to understand the workflows that use them.
+- In general, it is a best practice to minimize any side-effects of each action. Using atomic ("dumb") actions that have a clear and simple purpose will promote reuse and make it easier to understand the workflows that use them.
diff --git a/.github/workflows/deployExpensifyHelp.yml b/.github/workflows/deployExpensifyHelp.yml
@@ -31,8 +31,6 @@ jobs:
 
       - name: Setup NodeJS
         uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Setup Pages
         uses: actions/configure-pages@f156874f8191504dae5b037505266ed5dda6c382

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -14,8 +14,6 @@ jobs:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Lint JavaScript with ESLint
         run: npm run lint

diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml
@@ -37,8 +37,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - uses: ruby/setup-ruby@eae47962baca661befdfd24e4d6c34ade04858f7
         with:
@@ -110,8 +108,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Decrypt Developer ID Certificate
         run: cd desktop && gpg --quiet --batch --yes --decrypt --passphrase="$DEVELOPER_ID_SECRET_PASSPHRASE" --output developer_id.p12 developer_id.p12.gpg
@@ -149,8 +145,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - uses: ruby/setup-ruby@eae47962baca661befdfd24e4d6c34ade04858f7
         with:
@@ -237,8 +231,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Setup Cloudflare CLI
         run: pip3 install cloudflare
@@ -366,8 +358,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Set version
         run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV"

diff --git a/.github/workflows/reassurePerformanceTests.yml b/.github/workflows/reassurePerformanceTests.yml
@@ -15,8 +15,6 @@ jobs:
 
       - name: Setup NodeJS
         uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Run performance testing script
         shell: bash

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -21,8 +21,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Get number of CPU cores
         id: cpu-cores
@@ -46,8 +44,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Storybook run
         run: npm run storybook -- --smoke-test --ci
@@ -60,8 +56,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Test CI git logic
         run: tests/unit/CIGitLogicTest.sh
diff --git a/.github/workflows/testBuild.yml b/.github/workflows/testBuild.yml
@@ -81,8 +81,6 @@ jobs:
           echo "PULL_REQUEST_NUMBER=$PULL_REQUEST_NUMBER" >> .env.adhoc
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - uses: ruby/setup-ruby@eae47962baca661befdfd24e4d6c34ade04858f7
         with:
@@ -141,8 +139,6 @@ jobs:
           echo "PULL_REQUEST_NUMBER=$PULL_REQUEST_NUMBER" >> .env.adhoc
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Setup Xcode
         run: sudo xcode-select -switch /Applications/Xcode_14.2.app
@@ -207,8 +203,6 @@ jobs:
           echo "PULL_REQUEST_NUMBER=$PULL_REQUEST_NUMBER" >> .env.adhoc
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Decrypt Developer ID Certificate
         run: cd desktop && gpg --quiet --batch --yes --decrypt --passphrase="$DEVELOPER_ID_SECRET_PASSPHRASE" --output developer_id.p12 developer_id.p12.gpg
@@ -250,8 +244,6 @@ jobs:
           echo "PULL_REQUEST_NUMBER=$PULL_REQUEST_NUMBER" >> .env.adhoc
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Configure AWS Credentials
         uses: Expensify/App/.github/actions/composite/configureAwsCredentials@main

diff --git a/.github/workflows/typecheck.yml b/.github/workflows/typecheck.yml
@@ -14,8 +14,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - name: Type check with TypeScript
         run: npm run typecheck

diff --git a/.github/workflows/validateDocsRoutes.yml b/.github/workflows/validateDocsRoutes.yml
@@ -14,8 +14,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       # Verify that no new hubs were created without adding their metadata to _routes.yml
       - name: Validate Docs Routes File

diff --git a/.github/workflows/validateGithubActions.yml b/.github/workflows/validateGithubActions.yml
@@ -15,8 +15,6 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       # Rebuild all the actions on this branch and check for a diff. Fail if there is one,
       # because that would be a sign that the PR author did not rebuild the Github Actions

diff --git a/.github/workflows/verifyPodfile.yml b/.github/workflows/verifyPodfile.yml
@@ -17,7 +17,5 @@ jobs:
       - uses: actions/checkout@v3
 
       - uses: Expensify/App/.github/actions/composite/setupNode@main
-        with:
-          MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
 
       - run: ./.github/scripts/verifyPodfile.sh