Simplify conditions

Expensify · Mar 28, 2024 · be315d6 · be315d6
1 parent e4a1305
commit be315d6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts
@@ -779,9 +779,11 @@ function openReport(
             {optimisticData, successData, failureData},
             {
                 getConflictingRequests: (persistedRequests) =>
-                    persistedRequests.filter(
-                        (request) => request.command === WRITE_COMMANDS.OPEN_REPORT && request.data?.reportID === reportID && !isCreatingNewReport && !request.data?.createdReportActionID,
-                    ),
+                    // requests conflict only if:
+                    // 1. they are OpenReport commands
+                    // 2. they have the same reportID
+                    // 3. they are not creating a report - all calls to OpenReport that create a report will be unique and have a unique createdReportActionID
+                    persistedRequests.filter((request) => request.command === WRITE_COMMANDS.OPEN_REPORT && request.data?.reportID === reportID && !request.data?.createdReportActionID),
             },
         );
     }