Merge pull request #28810 from shubham1206agra/fix-persisted-requests

Fix: RBR - Deleted error notifications reappear after reloading
Expensify · Oct 6, 2023 · c5e1049 · c5e1049
2 parents 5fcdfd9 + ae8cb00
commit c5e1049
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/libs/actions/PersistedRequests.ts b/src/libs/actions/PersistedRequests.ts
@@ -33,11 +33,11 @@ function remove(requestToRemove: Request) {
      * We only remove the first matching request because the order of requests matters.
      * If we were to remove all matching requests, we can end up with a final state that is different than what the user intended.
      */
-    const index = persistedRequests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));
+    const requests = [...persistedRequests];
+    const index = requests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));
     if (index === -1) {
         return;
     }
-    const requests = [...persistedRequests];
     requests.splice(index, 1);
     persistedRequests = requests;
     Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);