Merge pull request #24586 from WikusKriek/23438-Historical-IOUs-appea…

…ring-in-LHN-like-a-pinned-chat

23438 historical IOUs appearing in LHN under pinned chats

src/libs/ReportUtils.js

@@ -1106,7 +1106,7 @@ function isWaitingForIOUActionFromCurrentUser(report) {
     }
 
     // Money request waiting for current user to add their credit bank account
-    if (report.ownerAccountID === currentUserAccountID && report.isWaitingOnBankAccount) {
+    if (report.hasOutstandingIOU && report.ownerAccountID === currentUserAccountID && report.isWaitingOnBankAccount) {
         return true;
     }
 

src/libs/SidebarUtils.js

@@ -112,7 +112,7 @@ function getOrderedReportIDs(currentReportId, allReportsDict, betas, policies, p
     // 1. Pinned - Always sorted by reportDisplayName
     // 2. Outstanding IOUs - Always sorted by iouReportAmount with the largest amounts at the top of the group
     // 3. Drafts - Always sorted by reportDisplayName
-    // 4. Non-archived reports
+    // 4. Non-archived reports and settled IOUs
     //      - Sorted by lastVisibleActionCreated in default (most recent) view mode
     //      - Sorted by reportDisplayName in GSD (focus) view mode
     // 5. Archived reports

tests/unit/ReportUtilsTest.js

@@ -309,16 +309,25 @@ describe('ReportUtils', () => {
                 expect(ReportUtils.isWaitingForIOUActionFromCurrentUser(report)).toBe(false);
             });
         });
-        it('returns true when the report has no oustanding IOU but is waiting for a bank account and the logged user is the report owner', () => {
+        it('returns false when the report has no oustanding IOU but is waiting for a bank account and the logged user is the report owner', () => {
             const report = {
                 ...LHNTestUtils.getFakeReport(),
                 hasOutstandingIOU: false,
                 ownerAccountID: currentUserAccountID,
                 isWaitingOnBankAccount: true,
             };
+            expect(ReportUtils.isWaitingForIOUActionFromCurrentUser(report)).toBe(false);
+        });
+        it('returns true when the report has oustanding IOU and is waiting for a bank account and the logged user is the report owner', () => {
+            const report = {
+                ...LHNTestUtils.getFakeReport(),
+                hasOutstandingIOU: true,
+                ownerAccountID: currentUserAccountID,
+                isWaitingOnBankAccount: true,
+            };
             expect(ReportUtils.isWaitingForIOUActionFromCurrentUser(report)).toBe(true);
         });
-        it('returns true when the report has no oustanding IOU but is waiting for a bank account and the logged user is not the report owner', () => {
+        it('returns false when the report has no oustanding IOU but is waiting for a bank account and the logged user is not the report owner', () => {
             const report = {
                 ...LHNTestUtils.getFakeReport(),
                 hasOutstandingIOU: false,