Apply suggestions from code review

Co-authored-by: Carlos Martins <luacmartins@gmail.com> Co-authored-by: Ishpaul Singh <104348397+ishpaul777@users.noreply.github.com>
Expensify · Mar 13, 2024 · cc1ca4e · cc1ca4e
1 parent 3d51305
commit cc1ca4e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/components/SelectionList/BaseListItem.tsx b/src/components/SelectionList/BaseListItem.tsx
@@ -24,7 +24,7 @@ function BaseListItem<TItem extends ListItem>({
     onCheckboxPress,
     onDismissError = () => {},
     rightHandSideComponent,
-    checkmarkPosition = 'left',
+    checkmarkPosition = CONST.DIRECTION.LEFT,
     keyForList,
     errors,
     pendingAction,
@@ -78,7 +78,7 @@ function BaseListItem<TItem extends ListItem>({
                 style={pressableStyle}
             >
                 <View style={wrapperStyle}>
-                    {canSelectMultiple && checkmarkPosition === 'left' && (
+                    {canSelectMultiple && checkmarkPosition === CONST.DIRECTION.LEFT && (
                         <PressableWithFeedback
                             accessibilityLabel={item.text ?? ''}
                             role={CONST.ROLE.BUTTON}
@@ -101,7 +101,7 @@ function BaseListItem<TItem extends ListItem>({
 
                     {typeof children === 'function' ? children(hovered) : children}
 
-                    {canSelectMultiple && checkmarkPosition === 'right' && (
+                    {canSelectMultiple && checkmarkPosition === CONST.DIRECTION.RIGHT && (
                         <PressableWithFeedback
                             onPress={handleCheckboxPress}
                             disabled={isDisabled}

diff --git a/src/components/SelectionList/types.ts b/src/components/SelectionList/types.ts
@@ -35,7 +35,7 @@ type CommonListItemProps<TItem> = {
     rightHandSideComponent?: ((item: TItem) => ReactElement<TItem>) | ReactElement | null;
 
     /** Direction of checkmark to show */
-    checkmarkPosition?: 'left' | 'right';
+    checkmarkPosition?: ValueOf<typeof CONST.DIRECTION>;
 
     /** Styles for the pressable component */
     pressableStyle?: StyleProp<ViewStyle>;
@@ -271,7 +271,7 @@ type BaseSelectionListProps<TItem extends ListItem> = Partial<ChildrenProps> & {
     rightHandSideComponent?: ((item: ListItem) => ReactElement<ListItem>) | ReactElement | null;
 
     /** Direction of checkmark to show */
-    checkmarkPosition?: 'left' | 'right';
+    checkmarkPosition?: ValueOf<typeof CONST.DIRECTION>;
 
     /** Whether to show the loading indicator for new options */
     isLoadingNewOptions?: boolean;

diff --git a/src/pages/workspace/WorkspaceInvitePage.tsx b/src/pages/workspace/WorkspaceInvitePage.tsx
@@ -321,7 +321,7 @@ function WorkspaceInvitePage({
                     showScrollIndicator
                     showLoadingPlaceholder={!didScreenTransitionEnd || !OptionsListUtils.isPersonalDetailsReady(personalDetailsProp)}
                     shouldPreventDefaultFocusOnSelectRow={!DeviceCapabilities.canUseTouchScreen()}
-                    checkmarkPosition="right"
+                    checkmarkPosition={CONST.DIRECTION.RIGHT}
                 />
                 <View style={[styles.flexShrink0]}>
                     <FormAlertWithSubmitButton