-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #27025 from software-mansion-labs/refactor-form-co…
…mponent Refactor form component
- Loading branch information
Showing
5 changed files
with
502 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import {createContext} from 'react'; | ||
|
||
const FormContext = createContext({}); | ||
export default FormContext; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,260 @@ | ||
import React, {createRef, useCallback, useMemo, useRef, useState} from 'react'; | ||
import _ from 'underscore'; | ||
import {withOnyx} from 'react-native-onyx'; | ||
import PropTypes from 'prop-types'; | ||
import lodashGet from 'lodash/get'; | ||
import Visibility from '../../libs/Visibility'; | ||
import * as FormActions from '../../libs/actions/FormActions'; | ||
import FormContext from './FormContext'; | ||
import FormWrapper from './FormWrapper'; | ||
import compose from '../../libs/compose'; | ||
import {withNetwork} from '../OnyxProvider'; | ||
import stylePropTypes from '../../styles/stylePropTypes'; | ||
import networkPropTypes from '../networkPropTypes'; | ||
|
||
const propTypes = { | ||
/** A unique Onyx key identifying the form */ | ||
formID: PropTypes.string.isRequired, | ||
|
||
/** Text to be displayed in the submit button */ | ||
submitButtonText: PropTypes.string.isRequired, | ||
|
||
/** Controls the submit button's visibility */ | ||
isSubmitButtonVisible: PropTypes.bool, | ||
|
||
/** Callback to validate the form */ | ||
validate: PropTypes.func, | ||
|
||
/** Callback to submit the form */ | ||
onSubmit: PropTypes.func.isRequired, | ||
|
||
/** Children to render. */ | ||
children: PropTypes.oneOfType([PropTypes.func, PropTypes.node]).isRequired, | ||
|
||
/* Onyx Props */ | ||
|
||
/** Contains the form state that must be accessed outside of the component */ | ||
formState: PropTypes.shape({ | ||
/** Controls the loading state of the form */ | ||
isLoading: PropTypes.bool, | ||
|
||
/** Server side errors keyed by microtime */ | ||
errors: PropTypes.objectOf(PropTypes.string), | ||
|
||
/** Field-specific server side errors keyed by microtime */ | ||
errorFields: PropTypes.objectOf(PropTypes.objectOf(PropTypes.string)), | ||
}), | ||
|
||
/** Should the button be enabled when offline */ | ||
enabledWhenOffline: PropTypes.bool, | ||
|
||
/** Whether the form submit action is dangerous */ | ||
isSubmitActionDangerous: PropTypes.bool, | ||
|
||
/** Whether ScrollWithContext should be used instead of regular ScrollView. | ||
* Set to true when there's a nested Picker component in Form. | ||
*/ | ||
scrollContextEnabled: PropTypes.bool, | ||
|
||
/** Container styles */ | ||
style: stylePropTypes, | ||
|
||
/** Custom content to display in the footer after submit button */ | ||
footerContent: PropTypes.oneOfType([PropTypes.func, PropTypes.node]), | ||
|
||
/** Information about the network */ | ||
network: networkPropTypes.isRequired, | ||
|
||
shouldValidateOnBlur: PropTypes.bool, | ||
|
||
shouldValidateOnChange: PropTypes.bool, | ||
}; | ||
|
||
const defaultProps = { | ||
isSubmitButtonVisible: true, | ||
formState: { | ||
isLoading: false, | ||
}, | ||
enabledWhenOffline: false, | ||
isSubmitActionDangerous: false, | ||
scrollContextEnabled: false, | ||
footerContent: null, | ||
style: [], | ||
validate: () => {}, | ||
shouldValidateOnBlur: true, | ||
shouldValidateOnChange: true, | ||
}; | ||
|
||
function getInitialValueByType(valueType) { | ||
switch (valueType) { | ||
case 'string': | ||
return ''; | ||
case 'boolean': | ||
return false; | ||
case 'date': | ||
return new Date(); | ||
default: | ||
return ''; | ||
} | ||
} | ||
|
||
function FormProvider({validate, shouldValidateOnBlur, shouldValidateOnChange, children, formState, network, enabledWhenOffline, onSubmit, ...rest}) { | ||
const inputRefs = useRef(null); | ||
const touchedInputs = useRef({}); | ||
const [inputValues, setInputValues] = useState({}); | ||
const [errors, setErrors] = useState({}); | ||
|
||
const onValidate = useCallback( | ||
(values) => { | ||
const validateErrors = validate(values); | ||
setErrors(validateErrors); | ||
}, | ||
[validate], | ||
); | ||
|
||
/** | ||
* @param {String} inputID - The inputID of the input being touched | ||
*/ | ||
const setTouchedInput = useCallback( | ||
(inputID) => { | ||
touchedInputs.current[inputID] = true; | ||
}, | ||
[touchedInputs], | ||
); | ||
|
||
const submit = useCallback(() => { | ||
// Return early if the form is already submitting to avoid duplicate submission | ||
if (formState.isLoading) { | ||
return; | ||
} | ||
|
||
// Touches all form inputs so we can validate the entire form | ||
_.each(inputRefs.current, (inputRef, inputID) => (touchedInputs.current[inputID] = true)); | ||
|
||
// Validate form and return early if any errors are found | ||
if (!_.isEmpty(onValidate(inputValues))) { | ||
return; | ||
} | ||
|
||
// Do not submit form if network is offline and the form is not enabled when offline | ||
if (network.isOffline && !enabledWhenOffline) { | ||
return; | ||
} | ||
|
||
onSubmit(inputValues); | ||
}, [enabledWhenOffline, formState.isLoading, inputValues, network.isOffline, onSubmit, onValidate]); | ||
|
||
const registerInput = useCallback( | ||
(inputID, propsToParse = {}) => { | ||
const newRef = propsToParse.ref || createRef(); | ||
inputRefs[inputID] = newRef; | ||
|
||
if (!_.isUndefined(propsToParse.value)) { | ||
inputValues[inputID] = propsToParse.value; | ||
} else if (propsToParse.shouldUseDefaultValue) { | ||
// We force the form to set the input value from the defaultValue props if there is a saved valid value | ||
inputValues[inputID] = propsToParse.defaultValue; | ||
} else if (_.isUndefined(inputValues[inputID])) { | ||
// We want to initialize the input value if it's undefined | ||
inputValues[inputID] = _.isUndefined(propsToParse.defaultValue) ? getInitialValueByType(propsToParse.valueType) : propsToParse.defaultValue; | ||
} | ||
|
||
const errorFields = lodashGet(formState, 'errorFields', {}); | ||
const fieldErrorMessage = | ||
_.chain(errorFields[inputID]) | ||
.keys() | ||
.sortBy() | ||
.reverse() | ||
.map((key) => errorFields[inputID][key]) | ||
.first() | ||
.value() || ''; | ||
|
||
return { | ||
...propsToParse, | ||
ref: newRef, | ||
inputID, | ||
key: propsToParse.key || inputID, | ||
errorText: errors[inputID] || fieldErrorMessage, | ||
value: inputValues[inputID], | ||
// As the text input is controlled, we never set the defaultValue prop | ||
// as this is already happening by the value prop. | ||
defaultValue: undefined, | ||
onTouched: (event) => { | ||
setTouchedInput(inputID); | ||
if (_.isFunction(propsToParse.onTouched)) { | ||
propsToParse.onTouched(event); | ||
} | ||
}, | ||
onBlur: (event) => { | ||
// Only run validation when user proactively blurs the input. | ||
if (Visibility.isVisible() && Visibility.hasFocus()) { | ||
// We delay the validation in order to prevent Checkbox loss of focus when | ||
// the user is focusing a TextInput and proceeds to toggle a CheckBox in | ||
// web and mobile web platforms. | ||
setTimeout(() => { | ||
setTouchedInput(inputID); | ||
if (shouldValidateOnBlur) { | ||
onValidate(inputValues); | ||
} | ||
}, 200); | ||
} | ||
|
||
if (_.isFunction(propsToParse.onBlur)) { | ||
propsToParse.onBlur(event); | ||
} | ||
}, | ||
onInputChange: (value, key) => { | ||
const inputKey = key || inputID; | ||
setInputValues((prevState) => { | ||
const newState = { | ||
...prevState, | ||
[inputKey]: value, | ||
}; | ||
|
||
if (shouldValidateOnChange) { | ||
onValidate(newState); | ||
} | ||
return newState; | ||
}); | ||
|
||
if (propsToParse.shouldSaveDraft) { | ||
FormActions.setDraftValues(propsToParse.formID, {[inputKey]: value}); | ||
} | ||
|
||
if (_.isFunction(propsToParse.onValueChange)) { | ||
propsToParse.onValueChange(value, inputKey); | ||
} | ||
}, | ||
}; | ||
}, | ||
[errors, formState, inputValues, onValidate, setTouchedInput, shouldValidateOnBlur, shouldValidateOnChange], | ||
); | ||
const value = useMemo(() => ({registerInput}), [registerInput]); | ||
|
||
return ( | ||
<FormContext.Provider value={value}> | ||
{/* eslint-disable react/jsx-props-no-spreading */} | ||
<FormWrapper | ||
{...rest} | ||
onSubmit={submit} | ||
inputRefs={inputRefs} | ||
errors={errors} | ||
> | ||
{children} | ||
</FormWrapper> | ||
</FormContext.Provider> | ||
); | ||
} | ||
|
||
FormProvider.displayName = 'Form'; | ||
FormProvider.propTypes = propTypes; | ||
FormProvider.defaultProps = defaultProps; | ||
|
||
export default compose( | ||
withNetwork(), | ||
withOnyx({ | ||
formState: { | ||
key: (props) => props.formID, | ||
}, | ||
}), | ||
)(FormProvider); |
Oops, something went wrong.