add comment

Expensify · May 8, 2023 · ec87028 · ec87028
1 parent 8cdba0e
commit ec87028
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/components/Tooltip/index.js b/src/components/Tooltip/index.js
@@ -184,7 +184,6 @@ class Tooltip extends PureComponent {
             <>
                 {this.state.isRendered && (
                     <TooltipRenderedOnPageBody
-                        key={[this.props.text, ...this.props.renderTooltipContentKey]}
                         animation={this.animation}
                         windowWidth={this.props.windowWidth}
                         xOffset={this.state.xOffset}
@@ -197,6 +196,10 @@ class Tooltip extends PureComponent {
                         maxWidth={this.props.maxWidth}
                         numberOfLines={this.props.numberOfLines}
                         renderTooltipContent={this.props.renderTooltipContent}
+
+                        // We pass a key, so whenever the content changes this component will completely remount with a fresh state.
+                        // This prevents flickering/moving while remaining performant.
+                        key={[this.props.text, ...this.props.renderTooltipContentKey]}
                     />
                 )}
                 <Hoverable