Merge pull request #20815 from adamgrzybowski/@swm/navigation-refacto…

…r-correct-stack-pop fix: dispatch pop always at the root state
Expensify · Jun 16, 2023 · ed1cdb3 · ed1cdb3
2 parents 7b00c47 + 1b11c8c
commit ed1cdb3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/HeaderWithBackButton.js b/src/components/HeaderWithBackButton.js
@@ -120,8 +120,8 @@ const defaultProps = {
     title: '',
     subtitle: '',
     onDownloadButtonPress: () => {},
-    onBackButtonPress: Navigation.goBack,
-    onCloseButtonPress: Navigation.dismissModal,
+    onBackButtonPress: () => Navigation.goBack(),
+    onCloseButtonPress: () => Navigation.dismissModal(),
     onThreeDotsButtonPress: () => {},
     shouldShowBorderBottom: false,
     shouldShowDownloadButton: false,

diff --git a/src/libs/Navigation/Navigation.js b/src/libs/Navigation/Navigation.js
@@ -136,7 +136,7 @@ function dismissModal(targetReportID) {
             action.type = 'REPLACE';
             navigationRef.current.dispatch(action);
         } else {
-            navigationRef.current.dispatch(StackActions.pop());
+            navigationRef.current.dispatch({...StackActions.pop(), target: rootState.key});
         }
     } else {
         Log.hmmm('[Navigation] dismissModal failed because there is no modal stack to dismiss');