Skip to content

Commit

Permalink
Merge pull request #10007 from Expensify/vit-updateGettingInternalQAURL
Browse files Browse the repository at this point in the history
[NoQA] Parse URLs correctly from the internalQA section of the staging deploy issue
  • Loading branch information
madmax330 authored Jul 19, 2022
2 parents 4bd5d58 + cb072f4 commit fb6766f
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/actions/javascript/awaitStagingDeploys/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/checkDeployBlockers/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/getPullRequestDetails/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/getReleaseBody/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/isPullRequestMergeable/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/isStagingDeployLocked/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/reopenIssueWithComment/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/triggerWorkflowAndWait/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/verifySignedCommits/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion .github/libs/GithubUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class GithubUtils {
const internalQAPRs = _.map(
[...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))],
match => ({
url: match[2],
url: match[2].split('-')[0].trim(),
number: Number.parseInt(match[3], 10),
isResolved: match[1] === 'x',
isAccessible: false,
Expand Down

0 comments on commit fb6766f

Please sign in to comment.