Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - New Chat and New Group is broken - list of users is blank #10079

Closed
kbecciv opened this issue Jul 25, 2022 · 13 comments
Closed

Android - New Chat and New Group is broken - list of users is blank #10079

kbecciv opened this issue Jul 25, 2022 · 13 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jul 25, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Tap on Fub menu

Additional information:

Expected Result:

New Chat and New Group is broken - list of users should appear

Actual Result:

New Chat and New Group is broken - list of users is blank

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.86.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): expensifail account

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220725-135928_New.Expensify.mp4
Screen_Recording_20220725-135330_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 25, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pecanoro
Copy link
Contributor

This happens when the keyboard is open but if the keyboard is closed, you can see the member list.

@pecanoro
Copy link
Contributor

I think this PR might have broken this when changing the KeyboardAvoidingView. cc/ @jasperhuangg @marcaaron @iwiznia @arosiclair

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Jul 25, 2022

Ahh, the missing options list under new chat must be because of how views and flexbox are platform dependent; the view that contains the options list probably isn't growing to fill the flex container.

As for the missing FAB options I don't think they would be affected by my PR.

I tested this on the Android emulator and it worked fine, I'm assuming it's only reproducible on a physical device.

I'm OOO today, any chance we could deploy without this? Retesting after fixing is probably going to take a while given all the different views that this feature touches.

@jasperhuangg jasperhuangg self-assigned this Jul 25, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Jul 25, 2022

Let's revert the PR then?

@pecanoro
Copy link
Contributor

There are no missing FAB options, the problem is only the keyboard opening, I tried on my phone and I was able to reproduce so unless we want all phones with the bug I am with Ioni, we should revert the PR until we get to fix it.

@pecanoro pecanoro removed their assignment Jul 26, 2022
@luacmartins
Copy link
Contributor

@jasperhuangg can we revert this PR since it seems to be causing this issue?

@jasperhuangg jasperhuangg changed the title Android - Missing Request, Split and New Room options under Fub menu, New Chat and New Group is broken - list of users is blank Android - New Chat and New Group is broken - list of users is blank Jul 26, 2022
@luacmartins
Copy link
Contributor

@kbecciv we reverted the PR that may have caused this issue. Can we retest and close this issue if it's a pass? Thank you!

@luacmartins
Copy link
Contributor

This seems to have been fixed by the revert. Closing!

@kbecciv
Copy link
Author

kbecciv commented Aug 2, 2022

@luacmartins Issue is still exist in Android app on build 1.1.86.8
Screenshot_20220802-165203_New Expensify
Screenshot_20220802-165209_New Expensify

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 2, 2022
@luacmartins
Copy link
Contributor

Hmm I'll reopen it to investigate then, but I don't think it's a blocker anymore

@jasperhuangg
Copy link
Contributor

There are no missing FAB options, the problem is only the keyboard opening

@kbecciv @pecanoro mentioned that there aren't any missing FAB options, the main bug here is the problem with displaying the list of users in the New Chat and New Group pages, which both have been resolved in #10140

Therefore I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants