Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-08-01 #10169

Closed
95 tasks done
OSBotify opened this issue Aug 1, 2022 · 19 comments
Closed
95 tasks done

Deploy Checklist: New Expensify 2022-08-01 #10169

OSBotify opened this issue Aug 1, 2022 · 19 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2022 •
edited by yuwenmemon
Loading

Release Version: 1.1.87-9
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@roryabraham
Copy link
Contributor

We're currently investigating a deploy issue. Please keep the checklist unlocked for the time being

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Aug 2, 2022
@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 2, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.87-8 🚀

@Julesssss
Copy link
Contributor

Checked off #10224 as a blocker. It's very minor and we're still discussing how to handle.

@yuwenmemon
Copy link
Contributor

Checked off #10215 as a blocker based on #10215 (comment)

@mvtglobally
Copy link

@yuwenmemon Regression sis completed
Deploy Blocker open #10217

PR #9696 is failing due to #10217
PR #9831 is failing due to #8497. Not a blocker. Checking off
PR #9954 is failing due to #10223. Not a blocker
PR #9963 is failing due to #10220. Not a blocker
PR ##10028 Is failing on Android due to #10079. As per comment, no longer a blocker, checking off
PR #10037 is Blocked as we are no longer seeing WellsFargo to trigger onfido flow. Will you be able to validate internally?
PR #10072 We are directed to PROD KYC and unable to proceed. Will you be able to validate internally? (KI #10084)
PR #10080 is failing on Android with KI #10079.
PR #10135 is failing due to #10219
PR #10152 is failing on Android due to KI #10079.
PR #10161 is blocked by #10084 & #10094. Can you validate internally?
PR

issues logged
#10216
#10219
#10220
#10223
#10224
#10232

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 4, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.87-9 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 4, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.87-9 has been deployed to staging 🎉

@michaelhaxhiu
Copy link
Contributor

Seems we have a ton of deploy blockers this week.

@yuwenmemon
Copy link
Contributor

Whew! Let's get workin'!

@yuwenmemon
Copy link
Contributor

@mvtglobally looks like #10217 has been fixed in version v1.1.87-9 - can we retest everything that was blocked on that?

@yuwenmemon yuwenmemon mentioned this issue Aug 4, 2022
Merged
91 tasks
@mvtglobally
Copy link

#10217 is fixed in the new build.

Screen_Recording_20220804-134422_New.Expensify.mp4

@mvtglobally
Copy link

mvtglobally commented Aug 4, 2022 •
edited
Loading

@yuwenmemon Summary of Outstanding items

PR #9696 is failing due to #10217. We are retesting
PR #10037 is Blocked as we are no longer seeing WellsFargo to trigger onfido flow. Will you be able to validate internally?
PR #10072 We are directed to PROD KYC and unable to proceed. Will you be able to validate internally? (KI #10084)
PR #10161 is blocked by #10084 & #10094. Can you validate internally?
PR #10231 - retesting CP
PR #9706 is failing with #10243. Can we check off? Doesn't seem to be a blocker
PR #10118 retesting Android on new build. the max indicator was not showing.

@yuwenmemon
Copy link
Contributor

PR #9706 is failing with #10243. Can we check off? Doesn't seem to be a blocker

Yes, go for it - agreed it's not a blocker

@yuwenmemon
Copy link
Contributor

Checking off #10037

@yuwenmemon
Copy link
Contributor

@mvtglobally Okay looks like what's remaining is:

#9696

PR #9696 is failing due to #10217. We are retesting

#10118

PR #10118 retesting Android on new build. the max indicator was not showing.

#10231

PR #10231 - retesting CP

All awaiting on your retest on Android on the new build. Let me know if there's anything I can help with!

@mvtglobally
Copy link

Checking off #9696 & PR #10231

@mvtglobally
Copy link

mvtglobally commented Aug 4, 2022 •
edited
Loading

@yuwenmemon #10118 - We are stuck on one device, as popup over 50MB doesn't appear only on Android device. checked new build as well. Blocked to validate PR. Android builds are not working properly, but its hard to validate production to compare.
Asked few other testers to try same to see if its limited to 1 tester only.
Not sure if it is a deploy blocker

RPReplay_Final1659637704.MP4

@mvtglobally
Copy link

Checking off #10118
Screenshot_20220804-161650_New Expensify
8

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@yuwenmemon @Julesssss @michaelhaxhiu @applausebot @mvtglobally @roryabraham @OSBotify