Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone not showing correct timezone after save #10231

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

Beamanator
Copy link
Contributor

@Beamanator Beamanator commented Aug 3, 2022

cc @vitHoracek since you helped test my previous timezone change

Details

This was broken in this PR: #9696 because I assumed we could optimistically update timezone with automatic timezone, but that doesn't work when automatic timezone is not set

Note: In the videos you'll see that the "Save" button is sometimes grayed out / looks disabled too often -> This is being fixed in a different PR: #10229

Fixed Issues

$ #10217

Tests

  1. Open Settings -> Profile
  2. Modify timezone (sometimes change automatic setting, sometimes change timezone)
  3. Save profile
  4. Navigate back to Settings, then back to Profile
  5. Make sure the timezone shows what you previously set
  6. Repeat steps 2 - 5 with a variety of "automatic" settings, timezones, etc
  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

QA Steps

  1. Open Settings -> Profile
  2. Modify timezone (sometimes change automatic setting, sometimes change timezone)
  3. Save profile
  4. Navigate back to Settings, then back to Profile
  5. Make sure the timezone shows what you previously set
  6. Repeat steps 2 - 5 with a variety of "automatic" settings, timezones, etc
  • Verify that no errors appear in the JS console

Screenshots

In progress...

Web

Screen.Recording.2022-08-03.at.2.29.44.PM.mov

Mobile Web

Desktop

Screen.Recording.2022-08-03.at.2.37.23.PM.mov

iOS

Screen.Recording.2022-08-03.at.2.41.25.PM.mov

Android

@Beamanator Beamanator requested a review from a team as a code owner August 3, 2022 12:29
@Beamanator Beamanator self-assigned this Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from robertjchen and removed request for a team August 3, 2022 12:29
Copy link
Contributor

@robertjchen robertjchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small logic tweak

src/libs/actions/App.js Outdated Show resolved Hide resolved
@Beamanator
Copy link
Contributor Author

Updated!

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Beamanator Beamanator dismissed robertjchen’s stale review August 4, 2022 08:39

Got a LGTM after the tiny tweak - this also blocks deploy so want to merge and test in staging soon

@Beamanator Beamanator merged commit 703c451 into main Aug 4, 2022
@Beamanator Beamanator deleted the beaman-fixTimezoneNotRerendering branch August 4, 2022 08:39
OSBotify pushed a commit that referenced this pull request Aug 4, 2022
…ring

Fix timezone not showing correct timezone after save

(cherry picked from commit 703c451)
OSBotify added a commit that referenced this pull request Aug 4, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Aug 4, 2022

🚀 Cherry-picked to staging by @Beamanator in version: 1.1.87-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 4, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants