-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timezone not showing correct timezone after save #10231
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small logic tweak
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Got a LGTM after the tiny tweak - this also blocks deploy so want to merge and test in staging soon
…ring Fix timezone not showing correct timezone after save (cherry picked from commit 703c451)
…-10231 🍒 Cherry pick PR #10231 to staging 🍒
🚀 Cherry-picked to staging by @Beamanator in version: 1.1.87-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀
|
cc @vitHoracek since you helped test my previous timezone change
Details
This was broken in this PR: #9696 because I assumed we could optimistically update timezone with automatic timezone, but that doesn't work when automatic timezone is not set
Note: In the videos you'll see that the "Save" button is sometimes grayed out / looks disabled too often -> This is being fixed in a different PR: #10229
Fixed Issues
$ #10217
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
In progress...
Web
Screen.Recording.2022-08-03.at.2.29.44.PM.mov
Mobile Web
Desktop
Screen.Recording.2022-08-03.at.2.37.23.PM.mov
iOS
Screen.Recording.2022-08-03.at.2.41.25.PM.mov
Android