Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "7470 - added onLayout to textinput perent component & used dynamic he…" #10096

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Revert "7470 - added onLayout to textinput perent component & used dynamic he…" #10096

merged 1 commit into from
Jul 26, 2022

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jul 26, 2022 •
edited
Loading

Reverts #9294

Fixes #10085

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2022

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@marcaaron marcaaron marked this pull request as ready for review July 26, 2022 00:07
@marcaaron marcaaron requested a review from a team as a code owner July 26, 2022 00:07
@marcaaron marcaaron self-assigned this Jul 26, 2022
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team July 26, 2022 00:07
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@luacmartins
Copy link
Contributor

Merging to fix the deploy blocker. Thanks @marcaaron!

@luacmartins luacmartins merged commit 9c99a0d into main Jul 26, 2022
@luacmartins luacmartins deleted the revert-9294-white_gap_textinput_autofill branch July 26, 2022 01:44
OSBotify pushed a commit that referenced this pull request Jul 26, 2022
@luacmartins @OSBotify
Merge pull request #10096 from Expensify/revert-9294-white_gap_textin…
a45c4b4 
…put_autofill

Revert "7470 - added onLayout to textinput perent component & used dynamic he…"

(cherry picked from commit 9c99a0d)
@OSBotify OSBotify mentioned this pull request Jul 26, 2022
Merged
OSBotify added a commit that referenced this pull request Jul 26, 2022
@OSBotify
Merge pull request #10103 from Expensify/OSBotify-cherry-pick-staging…
d43e231 
…-10096

🍒 Cherry pick PR #10096 to staging 🍒
@OSBotify OSBotify mentioned this pull request Jul 26, 2022
Closed
92 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.86-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.86-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 2, 2022
Closed
95 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@marcaaron @luacmartins @OSBotify