Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments - User is taken to production flow for adding Personal bank account and VBA - Toggling staging server has no effect #10084

Closed
kavimuru opened this issue Jul 25, 2022 · 12 comments
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com and login
  2. Go to settings > preferences > toggle "use staging server"
  3. Click payments > Bank account
  4. Look for "Wells Fargo"
  5. Search for the "Wells Fargo" and initiate

Expected Result:

User should see "Wells Fargo" option and able to continue

Actual Result:

Bank name is not available in the list and searching and continuing triggers production flow
NOTE: Looks like toggling staging server is not effective. (We are blocked with all the regression test case which require adding VBA)

Workaround:

Unknwon

Platform:

Where is this issue occurring?

  • Web
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.86-0
Reproducible in staging?: y
Reproducible in production?: n/a
Email or phone of affected tester (no customers): applausetester+0716mn@applause.expensifail.com / Utest123
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5662706_Recording__367.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2022

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@danieldoglas
Copy link
Contributor

I'm not fully sure we would hide something on staging servers. Will ask this in slack.

@danieldoglas
Copy link
Contributor

This is related to this PR: #9423

Since we moved plaid's logic from web-s to web-e, changing the flag to use staging on web-s won't do anything in this flow anymore.

I'm putting this into a discussion that's happening right now about using staging env for web-e.

@luacmartins
Copy link
Contributor

@danieldoglas So should this be tested in production now?

@danieldoglas
Copy link
Contributor

I don't think Applause will have credentials for testing in production. There's a discussion ongoing right now. I think we'll actually send builds from staging pointing to staging soon. https://expensify.slack.com/archives/C03TQ48KC/p1658415135702599

@luacmartins
Copy link
Contributor

Sounds good! So we are either fixing it by pointing our staging build to staging API or doing internal prodQA for these?

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2022
@danieldoglas
Copy link
Contributor

moving this to weekly since it's in discussion

@melvin-bot
Copy link

melvin-bot bot commented Aug 10, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added the Overdue label Aug 10, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 10, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@iwiznia
Copy link
Contributor

iwiznia commented Aug 10, 2022

I think this will be solved by #10163 right?

@danieldoglas
Copy link
Contributor

it will! I'll close this and relate it on the other issue.

@danieldoglas
Copy link
Contributor

danieldoglas commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants