Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Localize decimal separator" #10129

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

sketchydroide
Copy link
Contributor

@sketchydroide sketchydroide commented Jul 27, 2022

CC @Santhosh-Sellavel
Reverts #9800

This PR add some issues and the C+ asked me to revert it.

Some more info here #10108 and #9497 (comment)

@sketchydroide sketchydroide requested a review from a team as a code owner July 27, 2022 12:24
@sketchydroide sketchydroide self-assigned this Jul 27, 2022
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team July 27, 2022 12:24
Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just updated the description with an additional link to the comment that asks for a revert.

@techievivek techievivek merged commit bfbdd4e into main Jul 27, 2022
@techievivek techievivek deleted the revert-9800-eVoloshchak_localizeDecimalSeparator branch July 27, 2022 12:48
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2022

🚀 Deployed to staging by @techievivek in version: 1.1.87-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Aug 4, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat mentioned this pull request Nov 10, 2022
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants