[HOLD for payment 2022-11-04] [$250] Touching/clicking on emoji picker in edit message closes the keyboard - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Website in mWeb
2. Open chat > send a message > edit message
3. Click/Touch on emoji picker.

Expected Result:

It should directly open the emoji picker instead of closing keyboard.

Actual Result:

It closes the keyboard.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.88-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-06-12.at.1.49.24.AM.mov

Expensify/Expensify Issue URL:
related to #9252

Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1654979150171379

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@deetergp 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[deetergp]

Looks like this can be external.

[melvin-bot]

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Note: This could be directly related to #9252.

[Tushu17]

I want to clarify a thing here, the bug #9252 and this bug are completely different bugs as:-

1. #9252 is only present in android app & this bug is present in mWeb in both android and Ios.
2. #9252 isn't a focus related issue, as after selecting emoji the edit message input field is in focused state but the keyboard isn't showing up. while in this issue, emoji box isn't opening up after first click( on first click the input field gets unfocused and on the second click it opens the emoji box)

We can fix this bug just by using true instead of false at:-

App/src/pages/home/report/ReportActionItemMessageEdit.js

Line 207 in dbfd0eb

toggleReportActionComposeView(false, VirtualKeyboard.shouldAssumeIsOpen());

Screen recording:-

Screen.Recording.2022-09-02.at.1.58.24.AM.mov

cc- @parasharrajat

[michaelhaxhiu]

@parasharrajat do you think our ongoing issue #9252 will include a fix for this bug, too? Or should we treat as it's own scope and fix it separately?

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[sobitneupane]

Proposal from @aimane-chnaif looks good to me. We already have logic to handle similar issue (for Save button and Cancel button):

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 209 to 211 in ce740fe

	if (_.contains([this.saveButtonID, this.cancelButtonID], lodashGet(event, 'nativeEvent.relatedTarget.id'))) {
	return;
	}

He is proposing to extend an existing logic (used for Save button and Cancel button) to emoji button as well.

🎀👀🎀 C+ reviewed

cc: @srikarparsi

[srikarparsi]

looks good, assigning you to the issue @aimane-chnaif

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @srikarparsi!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[arielgreen]

Offers sent in Upwork

[arielgreen]

PR in progress

[arielgreen]

Awaiting merge

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix "clicking on emoji picker in edit message closes the keyboard" #12051

If no regressions arise, payment will be issued on 2022-11-04. 🎊

[arielgreen]

Payment due tomorrow

[melvin-bot]

@sobitneupane, @arielgreen, @srikarparsi, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[arielgreen]

Paid.