Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb/safari - Chat - If user taps on the keyboard, they can scroll to show blank spaces #10406

Closed
kbecciv opened this issue Aug 16, 2022 · 14 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Aug 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid user
  3. Access any chat on mobile
  4. Tap on the input field
  5. With the keyboard open, scroll the screen up and down

Expected Result:

The user expects the screen not to show blank elements and to adjust to the users keyboard opened correctly

Actual Result:

The screen UI seems to "Break", if the user scrolls downwards, there is a huge blank space shown and the header can some times be "shakey" and if the user scrolls upwards after doing this, some elements of the UI can be hidden.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.88.13

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5691663_Header_seems_to_be_shakey.mp4
Bug5691663_Scrolling_after_tapping_the_keyboard_breaks_page_UI.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2022

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@neil-marcellini
Copy link
Contributor

I'm pretty sure that this is a mobile web only issue. It doesn't occur on iOS. We'll have to test Android. It won't happen on Desktop or Web because there is not an on screen keyboard. It looks pretty bad on mobile web so we should fix it.

@neil-marcellini neil-marcellini removed their assignment Aug 17, 2022
@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label Aug 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2022

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@puneetlath
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2022

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title mWeb/safari - Chat - If user taps on the keyboard, they can scroll to show blank spaces [$250] mWeb/safari - Chat - If user taps on the keyboard, they can scroll to show blank spaces Aug 18, 2022
@MadPharaoh
Copy link

MadPharaoh commented Aug 19, 2022

proposal

this issue with safari only Using any position: fixed on the dragable area so changing the position is the ideal solution

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 19, 2022
@Santhosh-Sellavel
Copy link
Collaborator

@MadPharaoh Can you elaborate your more also with code changes you are proposing. Also explain why it's the only ideal solution?

@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Aug 24, 2022

Waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2022
@parasharrajat
Copy link
Member

This issue has come up numerous times in different forms. I would suggest not accepting any proposals that do not absolutely work.

@Santhosh-Sellavel
Copy link
Collaborator

Thanks, @parasharrajat for jumping in here can you recall any previous issue ids which we can link here?

@parasharrajat
Copy link
Member

I would say we just close this for now.
#8731
#5894

There will be more...

@Santhosh-Sellavel
Copy link
Collaborator

@puneetlath What do you say then?

@puneetlath
Copy link
Contributor

I agree we should close in favor of #10273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants