-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] mWeb (Safari) - Dragging the screen up creates empty space between keyboard and composer - Reported by: @parasharrajat #5894
Comments
Triggered auto assignment to @Dal-Papa ( |
Looks like an aesthetic bug that can be tackled by contributors. |
Triggered auto assignment to @Christinadobrzyn ( |
This comment was marked as outdated.
This comment was marked as outdated.
Triggered auto assignment to @roryabraham ( |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@parasharrajat are you still interested in this job? |
Haven't looked at it yet. If I have a solution, I will propose here. Thanks for asking. 🙂 |
@Christinadobrzyn Not sure if fixable: https://stackoverflow.com/questions/61014250/empty-space-on-the-bottom-of-the-page-when-swipe-up-on-safari-ios . I tried the same as #5892 (comment) but didn't work. It seems that no matter what you add below the |
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for the insight @sidferreira - @roryabraham do you have any suggestions for that? |
I don't think that the answer provided in https://stackoverflow.com/questions/61014250/empty-space-on-the-bottom-of-the-page-when-swipe-up-on-safari-ios is relevant in this case because the white space persists after you lift your finger (i.e: it doesn't "bounce back"). This is definitely a bug in our application and not safari default behavior. |
Hey @roryabraham just catching up here, it looks like the fix for this was reverted due to subsequent bugs? Should I create a new Upwork job or are we going to fix this internally? |
@Christinadobrzyn that's correct – this was reverted due to subsequent bugs. And yes, let's create a new Upwork job please 🙂 |
Created a new Upwork job to fix these bugs Internal posting - https://www.upwork.com/ab/applicants/1527476784280002560/job-details |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Triggered auto assignment to @Beamanator ( |
@roryabraham looks like I got assigned b/c you're OOO today - I'm going to unassign since i believe you'll be back Monday, feel free to add me back if you need my help 👍 |
I believe that this is the same issue as #8731. On that issue my proposal was no action, as this overscroll behaviour appears to be in place on many major sites. |
Thanks for the comment @jrstanley.
|
No, I was already paid reporting bonus so I am good. |
Okay thanks for the update. |
Yep! just double-checking with @roryabraham about closing this in favour of #8731 |
This is fine with me as long as @luacmartins familiarizes himself with all the context in this issue and understands what's already been tried. @luacmartins if you feel confident in that, would you please close this out? |
Oof lots of comments here. I'll take a look tomorrow, but it seems like this issue has more context than #8731. |
The main thing that's already been tried is what was reverted here, and I think the other main suggestions are summarized at a high level in this comment. Hopefully that helps distill the issue for you 🙂 |
Thanks for the summary @roryabraham, that was really helpful! Closing this in favor of #8731 |
Cancelled the job in Upwork |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Dragging the screen up should not show any blank space
Actual Result:
Dragging the screen up shows a blank space
Workaround:
None needed, visual issue.
Platform:
Where is this issue occurring?
Version Number: 1.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633858525070700
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: