Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb (Safari) - Dragging the screen up creates empty space between keyboard and composer - Reported by: @parasharrajat #5894

Closed
isagoico opened this issue Oct 15, 2021 · 84 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to a conversation
  2. Tap on the composer box
  3. Drag the screen upwards

Expected Result:

Dragging the screen up should not show any blank space

Actual Result:

Dragging the screen up shows a blank space

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

  • Mobile Web (Safari)

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
image

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633858525070700

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @Dal-Papa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Dal-Papa
Copy link

Looks like an aesthetic bug that can be tackled by contributors.

@MelvinBot MelvinBot removed the Overdue label Oct 18, 2021
@Dal-Papa Dal-Papa added the External Added to denote the issue can be worked on by a contributor label Oct 18, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Christinadobrzyn

This comment was marked as outdated.

@MelvinBot MelvinBot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Daily KSv2 labels Oct 19, 2021
@MelvinBot
Copy link

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Christinadobrzyn

This comment was marked as outdated.

@roryabraham

This comment was marked as outdated.

@Christinadobrzyn
Copy link
Contributor

@parasharrajat are you still interested in this job?

@parasharrajat
Copy link
Member

Haven't looked at it yet. If I have a solution, I will propose here. Thanks for asking. 🙂

@sidferreira
Copy link
Contributor

sidferreira commented Nov 4, 2021

@Christinadobrzyn Not sure if fixable: https://stackoverflow.com/questions/61014250/empty-space-on-the-bottom-of-the-page-when-swipe-up-on-safari-ios . I tried the same as #5892 (comment) but didn't work. It seems that no matter what you add below the #root, safari will add ~200px more to scroll...

@Christinadobrzyn

This comment was marked as outdated.

@Christinadobrzyn
Copy link
Contributor

Thanks for the insight @sidferreira - @roryabraham do you have any suggestions for that?

@roryabraham
Copy link
Contributor

roryabraham commented Nov 5, 2021

I don't think that the answer provided in https://stackoverflow.com/questions/61014250/empty-space-on-the-bottom-of-the-page-when-swipe-up-on-safari-ios is relevant in this case because the white space persists after you lift your finger (i.e: it doesn't "bounce back"). This is definitely a bug in our application and not safari default behavior.

@roryabraham roryabraham reopened this May 15, 2022
@Christinadobrzyn
Copy link
Contributor

Hey @roryabraham just catching up here, it looks like the fix for this was reverted due to subsequent bugs? Should I create a new Upwork job or are we going to fix this internally?

@roryabraham
Copy link
Contributor

@Christinadobrzyn that's correct – this was reverted due to subsequent bugs. And yes, let's create a new Upwork job please 🙂

@Christinadobrzyn
Copy link
Contributor

Created a new Upwork job to fix these bugs

Internal posting - https://www.upwork.com/ab/applicants/1527476784280002560/job-details
External posting - https://www.upwork.com/nx/job-post/custom/preview?uid=1527476784280002560

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 20, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 20, 2022

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title mWeb (Safari) - Dragging the screen up creates empty space between keyboard and composer - Reported by: @parasharrajat [$250] mWeb (Safari) - Dragging the screen up creates empty space between keyboard and composer - Reported by: @parasharrajat May 20, 2022
@Beamanator
Copy link
Contributor

@roryabraham looks like I got assigned b/c you're OOO today - I'm going to unassign since i believe you'll be back Monday, feel free to add me back if you need my help 👍

@Beamanator Beamanator removed their assignment May 20, 2022
@jrstanley
Copy link
Contributor

I believe that this is the same issue as #8731. On that issue my proposal was no action, as this overscroll behaviour appears to be in place on many major sites.

@mananjadhav
Copy link
Collaborator

mananjadhav commented May 20, 2022

Thanks for the comment @jrstanley.

@Beamanator @roryabraham @Christinadobrzyn we can close this out in favor of the traction in #8731.

I would also like to highlight that this is reported by @parasharrajat long before the other issue and might be eligible for reporting bonus if we fix either of these issues. Already paid.

@parasharrajat
Copy link
Member

No, I was already paid reporting bonus so I am good.

@mananjadhav
Copy link
Collaborator

No, I was already paid reporting bonus so I am good.

Okay thanks for the update.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented May 24, 2022

Yep! just double-checking with @roryabraham about closing this in favour of #8731

@roryabraham
Copy link
Contributor

we can close this out in favor of the traction in #8731.

This is fine with me as long as @luacmartins familiarizes himself with all the context in this issue and understands what's already been tried. @luacmartins if you feel confident in that, would you please close this out?

@luacmartins
Copy link
Contributor

Oof lots of comments here. I'll take a look tomorrow, but it seems like this issue has more context than #8731.

@roryabraham
Copy link
Contributor

The main thing that's already been tried is what was reverted here, and I think the other main suggestions are summarized at a high level in this comment. Hopefully that helps distill the issue for you 🙂

@luacmartins
Copy link
Contributor

Thanks for the summary @roryabraham, that was really helpful! Closing this in favor of #8731

@Christinadobrzyn
Copy link
Contributor

Cancelled the job in Upwork

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests