[Planning] Dragging the attachment modal to the bottom misplaces it - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to a conversation
2. Send a image
3. Open the attachment preview
4. Drag the modal to the bottom

Expected Result:

Attachment preview modal should not move

Actual Result:

Attachment preview modal moves after dragged and stays misplaced.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633858422069300?thread_ts=1633858370.069100&cid=C01GTK53T8Q

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mallenexpensify]

Is this intentional to allow the user to double check who they're sending the file/image to?
Asking about in thread https://expensify.slack.com/archives/C01GTK53T8Q/p1634566956408100?thread_ts=1633858370.069100&cid=C01GTK53T8Q

[mallenexpensify]

Got some feedback from Bortman - link

I don’t think you should be able to drag the modal half way

[mallenexpensify]

Job posted https://www.upwork.com/jobs/~0101b4f84870ca5fc5

[MelvinBot]

Triggered auto assignment to @marcaaron (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcaaron]

Taking hold off.

[mallenexpensify]

Doubled price to $500

[sidferreira]

withdrawn

[parasharrajat]

@sidferreira I am sure we are not trying to remove the swiping behavior.

[sidferreira]

@parasharrajat mind explaining what is the desired behaviour? Cause the slack discussion sounded otherwise...

[parasharrajat]

Sure. This issue is specifically Affecting safari Mobile Web. IMO, as the issue says, when you drag it down it should be either closed or put back to normal. But not in the middle of the screen

Here is one discussion about it https://expensify.slack.com/archives/C01GTK53T8Q/p1634566956408100?thread_ts=1633858370.069100&cid=C01GTK53T8Q. Otherwise, CME(assigned engineer) will be able to help.

[sidferreira]

@parasharrajat So, the issue happens in iOS < 15, but seems to work fine in iOS >= 15.

[sidferreira]

@mallenexpensify It seems that adding overflow: hidden!important to the body tag fixes the issue.

So, my suggestion is to:

• add .block-pull-to-refresh { overflow: hidden!important; } to the index.html file
• add const blockPullToRefresh = navigator && navigator.appVersion && navigator.appVersion.indexOf('iPhone OS 1') >= 0; to AttachmentModal.js
• add if (blockPullToRefresh) { document.querySelector('body').classList.remove('block-pull-to-refresh'); } to the onClose of the attachment modal
• add if (blockPullToRefresh) { document.querySelector('body').classList.add('block-pull-to-refresh'); } to the onModalShowof the modal

This change would affect only iOS Web.

The change may be applied at BaseModal in order to ensure consistent behaviour.

[marcaaron]

Sorry, I'm not sure what more to do to move this conversation forward - it needs to be brought up in the channel and get input from the wider team #expensify-open-source. I can put a planning label on it for now.

[mallenexpensify]

Gonna bump to monthly for now since it's not a high-value issue

[mallenexpensify]

Interesting, I didn't think issues with the Planning label were supposed to go overdue, maybe that's currently only in the E/E repo and not E/App...

[mallenexpensify]

No update...

[mallenexpensify]

on hold/planning

[mallenexpensify]

Still on hold...

[mananjadhav]

Any specific reason we've put this into planning? I guess there isn't a solution to this with our RNModal implementation. Hence I recommended to disable it in the mWeb or we can close it?

cc - @mallenexpensify

[mallenexpensify]

I'm not sure what's best, it seems like things kinda stalled. @marcaaron thoughts on keeping this on hold, closing or removing the planning label?

[marcaaron]

I'm just gonna close it. Left a recommendation back then and doesn't seem like we came to any conclusion so - yeah seems even less valuable than we originally presumed.